From patchwork Thu Apr 4 18:46:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Limonciello, Mario" X-Patchwork-Id: 10886089 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 247A11708 for ; Thu, 4 Apr 2019 18:47:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0B7CC28732 for ; Thu, 4 Apr 2019 18:47:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F3A792880A; Thu, 4 Apr 2019 18:47:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 969A428732 for ; Thu, 4 Apr 2019 18:47:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729986AbfDDSrV (ORCPT ); Thu, 4 Apr 2019 14:47:21 -0400 Received: from esa7.dell-outbound.iphmx.com ([68.232.153.96]:16048 "EHLO esa7.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729456AbfDDSrS (ORCPT ); Thu, 4 Apr 2019 14:47:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=dell.com; i=@dell.com; q=dns/txt; s=smtpout; t=1554403635; x=1585939635; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=blPiuQw5mEA1nphC4CI7CGPcz/CtVQvVInVQvGTr75M=; b=Q8TEcZp2hUHRbQClnJBFM6nG+TQeuKdWkiHXjhdsxmM2X5YbZ+v+RAxl Va+f/U9yUxB91fqJDOf+rd/l38gf3GUZ+fsk+KduuuXGs9QL9mEDTUvIZ sqcyEA+tTPoGkXBS68vZfbIyaBgoZkPNFJiWx3ayC+6bZ/Yhvc1NjsQOS I=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2EABQAuTqZchyWd50NlHAEBAQQBAQcEAQGBZQKBKYJRJ4wsXaUNgXoOAQGEbAKFTiI8AgwBAQMBAQkBAwIBAQIQAQEBFQkIKS+COikBgmgCAQMSFVIQUVcZIoMAgXaiEz0Cb4EBiQcBAQGBazOKL4EwAQGGaYRIgVc/hGGEDYEEhRQDkl2TDQcCgk8EkScCGIF1klqfPwIEAgQFAhWBfQmBWHCDPIIkjkYhATKOG4JNAQE X-IPAS-Result: A2EABQAuTqZchyWd50NlHAEBAQQBAQcEAQGBZQKBKYJRJ4wsXaUNgXoOAQGEbAKFTiI8AgwBAQMBAQkBAwIBAQIQAQEBFQkIKS+COikBgmgCAQMSFVIQUVcZIoMAgXaiEz0Cb4EBiQcBAQGBazOKL4EwAQGGaYRIgVc/hGGEDYEEhRQDkl2TDQcCgk8EkScCGIF1klqfPwIEAgQFAhWBfQmBWHCDPIIkjkYhATKOG4JNAQE Received: from mx0b-00154901.pphosted.com ([67.231.157.37]) by esa7.dell-outbound.iphmx.com with ESMTP/TLS/AES256-SHA256; 04 Apr 2019 13:47:14 -0500 Received: from pps.filterd (m0144103.ppops.net [127.0.0.1]) by mx0b-00154901.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x34ISMQ6043163; Thu, 4 Apr 2019 14:47:16 -0400 Received: from ausxipps310.us.dell.com (AUSXIPPS310.us.dell.com [143.166.148.211]) by mx0b-00154901.pphosted.com with ESMTP id 2rnn028y88-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 04 Apr 2019 14:47:15 -0400 X-LoopCount0: from 10.173.37.27 X-IronPort-AV: E=Sophos;i="5.60,309,1549951200"; d="scan'208";a="337561725" From: Mario Limonciello To: linux-usb@vger.kernel.org Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, hayeswang@realtek.com, sjg@google.com, campello@google.com, Ryan Hong , Crag Wang , Mario Limonciello Subject: [PATCH v2 1/2] r8152: remove extra action copying ethernet address Date: Thu, 4 Apr 2019 13:46:52 -0500 Message-Id: <1554403613-5970-2-git-send-email-mario.limonciello@dell.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1554403613-5970-1-git-send-email-mario.limonciello@dell.com> References: <1554403613-5970-1-git-send-email-mario.limonciello@dell.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-04-04_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=750 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904040116 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This already happens later on in `rtl8152_set_mac_address` Signed-off-by: Mario Limonciello --- drivers/net/usb/r8152.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 86c8c64..dc1bfff 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -1212,7 +1212,6 @@ static int vendor_mac_passthru_addr_read(struct r8152 *tp, struct sockaddr *sa) goto amacout; } memcpy(sa->sa_data, buf, 6); - ether_addr_copy(tp->netdev->dev_addr, sa->sa_data); netif_info(tp, probe, tp->netdev, "Using pass-thru MAC addr %pM\n", sa->sa_data);