Message ID | 1569481230-14120-1-git-send-email-pawell@cadence.com (mailing list archive) |
---|---|
State | Superseded |
Headers | show |
Series | [-next] usb: cdns3: Fix sheduling with locks held. | expand |
On Thu, Sep 26, 2019 at 08:00:30AM +0100, Pawel Laszczak wrote: > Patch fix issue in cdns3_ep0_feature_handle_device function. > > The function usleep_range can't be used there because this function is > called with locks held and IRQs disabled in > cdns3_device_thread_irq_handler(). > > To resolve this issue patch replaces usleep_range with mdelay. > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Pawel Laszczak <pawell@cadence.com> > Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver") > --- > drivers/usb/cdns3/ep0.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Is this v2 of the patch? If so, it needs to be said so in the subject line, and below the --- line describe what changed from the previous one. That should all be described in the kernel documentation, right? v3 please? thanks, greg k-h
Hi, > > >On Thu, Sep 26, 2019 at 08:00:30AM +0100, Pawel Laszczak wrote: >> Patch fix issue in cdns3_ep0_feature_handle_device function. >> >> The function usleep_range can't be used there because this function is >> called with locks held and IRQs disabled in >> cdns3_device_thread_irq_handler(). >> >> To resolve this issue patch replaces usleep_range with mdelay. >> >> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> >> Signed-off-by: Pawel Laszczak <pawell@cadence.com> >> Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver") >> --- >> drivers/usb/cdns3/ep0.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > >Is this v2 of the patch? Really. It's the same patch as previous one. I added only Reported-by and Fixes. Ok I will prepare the next one :(. >If so, it needs to be said so in the subject line, and below the --- >line describe what changed from the previous one. > >That should all be described in the kernel documentation, right? > >v3 please? > >thanks, > >greg k-h Thenks, Pawell
diff --git a/drivers/usb/cdns3/ep0.c b/drivers/usb/cdns3/ep0.c index 44f652e8b5a2..0445da0a5a0c 100644 --- a/drivers/usb/cdns3/ep0.c +++ b/drivers/usb/cdns3/ep0.c @@ -332,7 +332,7 @@ static int cdns3_ep0_feature_handle_device(struct cdns3_device *priv_dev, * for sending status stage. * This time should be less then 3ms. */ - usleep_range(1000, 2000); + mdelay(1); cdns3_set_register_bit(&priv_dev->regs->usb_cmd, USB_CMD_STMODE | USB_STS_TMODE_SEL(tmode - 1));
Patch fix issue in cdns3_ep0_feature_handle_device function. The function usleep_range can't be used there because this function is called with locks held and IRQs disabled in cdns3_device_thread_irq_handler(). To resolve this issue patch replaces usleep_range with mdelay. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Pawel Laszczak <pawell@cadence.com> Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver") --- drivers/usb/cdns3/ep0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1