| Message ID | 1578537045-23260-2-git-send-email-hanjie.lin@amlogic.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: meson: Add support for USB on Amlogic A1 | expand |
On 09/01/2020 03:30, Hanjie Lin wrote: > Add the Amlogic A1 Family USB2 PHY Bindings > > It supports Host mode only. > > Signed-off-by: Hanjie Lin <hanjie.lin@amlogic.com> > Signed-off-by: Yue Wang <yue.wang@amlogic.com> > --- > .../bindings/phy/amlogic,meson-a1-usb2-phy.yaml | 56 ++++++++++++++++++++++ > 1 file changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml > new file mode 100644 > index 00000000..dd2e3a6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml > @@ -0,0 +1,56 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright 2019 Amlogic, Inc > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/phy/amlogic,meson-a1-usb2-phy.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Amlogic A1 USB2 PHY > + > +maintainers: > + - Yue Wang <yue.wang@amlogic.com> > + > +properties: > + compatible: > + const: amlogic,meson-a1-usb2-phy > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: xtal_usb_phy > + > + resets: > + maxItems: 1 Please use reset-names like the g12a bindings. Neil > + > + "#phy-cells": > + const: 0 > + > + power-domains: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - resets > + - "#phy-cells" > + - power-domains > + > +examples: > + - | > + usb2_phy1: phy@40000 { > + status = "okay"; > + compatible = "amlogic,a1-usb2-phy"; > + clocks = <&clkc_periphs 2>; > + clock-names = "xtal_usb_phy"; > + reg = <0x0 0x40000 0x0 0x2000>; > + resets = <&reset RESET_USBPHY>; > + #phy-cells = <0>; > + power-domains = <&pwrc PWRC_USB_ID>; > + }; >
On 2020/1/9 17:21, Neil Armstrong wrote: > On 09/01/2020 03:30, Hanjie Lin wrote: >> Add the Amlogic A1 Family USB2 PHY Bindings >> >> It supports Host mode only. >> >> Signed-off-by: Hanjie Lin <hanjie.lin@amlogic.com> >> Signed-off-by: Yue Wang <yue.wang@amlogic.com> >> --- >> .../bindings/phy/amlogic,meson-a1-usb2-phy.yaml | 56 ++++++++++++++++++++++ >> 1 file changed, 56 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml >> >> diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml >> new file mode 100644 >> index 00000000..dd2e3a6 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml >> @@ -0,0 +1,56 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +# Copyright 2019 Amlogic, Inc >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/phy/amlogic,meson-a1-usb2-phy.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >> + >> +title: Amlogic A1 USB2 PHY >> + >> +maintainers: >> + - Yue Wang <yue.wang@amlogic.com> >> + >> +properties: >> + compatible: >> + const: amlogic,meson-a1-usb2-phy >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + >> + clock-names: >> + items: >> + - const: xtal_usb_phy >> + >> + resets: >> + maxItems: 1 > > Please use reset-names like the g12a bindings. > > Neil > Ok, Neil I will revert reset-names change to keep consistence with G12A in next version. Thanks, Hanjie >> + >> + "#phy-cells": >> + const: 0 >> + >> + power-domains: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + - clock-names >> + - resets >> + - "#phy-cells" >> + - power-domains >> + >> +examples: >> + - | >> + usb2_phy1: phy@40000 { >> + status = "okay"; >> + compatible = "amlogic,a1-usb2-phy"; >> + clocks = <&clkc_periphs 2>; >> + clock-names = "xtal_usb_phy"; >> + reg = <0x0 0x40000 0x0 0x2000>; >> + resets = <&reset RESET_USBPHY>; >> + #phy-cells = <0>; >> + power-domains = <&pwrc PWRC_USB_ID>; >> + }; >> > > . >
On Thu, Jan 9, 2020 at 3:30 AM Hanjie Lin <hanjie.lin@amlogic.com> wrote: [...] > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: xtal_usb_phy the "usb_phy" part of "xtal_usb_phy" seems redundant to me: it's the XTAL clock input (this is what I'd expect as clock-name) of the USB PHY (this is already part of the node name). in addition to keeping the reset-names consistent (as Neil suggested) please also use the same clock-names as G12 Thank you! Martin
On 2020/1/10 1:12, Martin Blumenstingl wrote: > On Thu, Jan 9, 2020 at 3:30 AM Hanjie Lin <hanjie.lin@amlogic.com> wrote: > [...] >> + clocks: >> + maxItems: 1 >> + >> + clock-names: >> + items: >> + - const: xtal_usb_phy > the "usb_phy" part of "xtal_usb_phy" seems redundant to me: > it's the XTAL clock input (this is what I'd expect as clock-name) of > the USB PHY (this is already part of the node name). > in addition to keeping the reset-names consistent (as Neil suggested) > please also use the same clock-names as G12 > Of course. I will use "xtal" name in next version. Thanks, Hanjie > > Thank you! > Martin > > . >
diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml new file mode 100644 index 00000000..dd2e3a6 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml @@ -0,0 +1,56 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright 2019 Amlogic, Inc +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/phy/amlogic,meson-a1-usb2-phy.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Amlogic A1 USB2 PHY + +maintainers: + - Yue Wang <yue.wang@amlogic.com> + +properties: + compatible: + const: amlogic,meson-a1-usb2-phy + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + items: + - const: xtal_usb_phy + + resets: + maxItems: 1 + + "#phy-cells": + const: 0 + + power-domains: + maxItems: 1 + +required: + - compatible + - reg + - clocks + - clock-names + - resets + - "#phy-cells" + - power-domains + +examples: + - | + usb2_phy1: phy@40000 { + status = "okay"; + compatible = "amlogic,a1-usb2-phy"; + clocks = <&clkc_periphs 2>; + clock-names = "xtal_usb_phy"; + reg = <0x0 0x40000 0x0 0x2000>; + resets = <&reset RESET_USBPHY>; + #phy-cells = <0>; + power-domains = <&pwrc PWRC_USB_ID>; + };