| Message ID | 1620410119-24971-1-git-send-email-wcheng@codeaurora.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 18ffa988dbae69cc6e9949cddd9606f6fe533894 |
| Headers | show |
| Series | [v2] usb: dwc3: gadget: Return success always for kick transfer in ep queue | expand |
Wesley Cheng <wcheng@codeaurora.org> writes: > If an error is received when issuing a start or update transfer > command, the error handler will stop all active requests (including > the current USB request), and call dwc3_gadget_giveback() to notify > function drivers of the requests which have been stopped. Avoid > returning an error for kick transfer during EP queue, to remove > duplicate cleanup operations on the request being queued. > > Fixes: 8d99087c2db8 ("usb: dwc3: gadget: Properly handle failed kick_transfer") > cc: stable@vger.kernel.org Wrong format here, should be: Cc: <stable@vger.kernel.org> Other than that: Acked-by: Felipe Balbi <balbi@kernel.org>
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index dd80e5c..a5b7fd9 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -1684,7 +1684,9 @@ static int __dwc3_gadget_ep_queue(struct dwc3_ep *dep, struct dwc3_request *req) } } - return __dwc3_gadget_kick_transfer(dep); + __dwc3_gadget_kick_transfer(dep); + + return 0; } static int dwc3_gadget_ep_queue(struct usb_ep *ep, struct usb_request *request,
If an error is received when issuing a start or update transfer command, the error handler will stop all active requests (including the current USB request), and call dwc3_gadget_giveback() to notify function drivers of the requests which have been stopped. Avoid returning an error for kick transfer during EP queue, to remove duplicate cleanup operations on the request being queued. Fixes: 8d99087c2db8 ("usb: dwc3: gadget: Properly handle failed kick_transfer") cc: stable@vger.kernel.org Signed-off-by: Wesley Cheng <wcheng@codeaurora.org> --- Changes in v2: - Added Fixes tag and Cc'ed stable Changes in v1: - Renamed commit title due to new implementation - Return success always for kick transfer during ep queue Previous patchset: https://lore.kernel.org/linux-usb/875yzxibur.fsf@kernel.org/T/#t drivers/usb/dwc3/gadget.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)