| Message ID | 1625218655-14180-7-git-send-email-wcheng@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Re-introduce TX FIFO resize for larger EP bursting | expand |
On Fri, Jul 02, 2021 at 02:37:35AM -0700, Wesley Cheng wrote: > Update the tx-fifo-resize property with a better description, while > adding the tx-fifo-max-num, which is a new parameter allowing > adjustments for the maximum number of packets the txfifo resizing logic > can account for while resizing the endpoints. > > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Wesley Cheng <wcheng@codeaurora.org> > --- > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > index 41416fb..078fb78 100644 > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > @@ -289,10 +289,21 @@ properties: > maximum: 16 > > tx-fifo-resize: > - description: Determines if the FIFO *has* to be reallocated > - deprecated: true So this is NOT deprecated? Are we allowed to "bring back" things people thought were going away? thanks, greg k-h
diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml index 41416fb..078fb78 100644 --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml @@ -289,10 +289,21 @@ properties: maximum: 16 tx-fifo-resize: - description: Determines if the FIFO *has* to be reallocated - deprecated: true + description: Determines if the TX fifos can be dynamically resized depending + on the number of IN endpoints used and if bursting is supported. This + may help improve bandwidth on platforms with higher system latencies, as + increased fifo space allows for the controller to prefetch data into its + internal memory. type: boolean + tx-fifo-max-num: + description: Specifies the max number of packets the txfifo resizing logic + can account for when higher endpoint bursting is used. (bMaxBurst > 6) The + higher the number, the more fifo space the txfifo resizing logic will + allocate for that endpoint. + $ref: /schemas/types.yaml#/definitions/uint8 + minimum: 3 + snps,incr-burst-type-adjustment: description: Value for INCR burst type of GSBUSCFG0 register, undefined length INCR