diff mbox series

[v4,3/5] usb: host: xhci-plat: support override of hc driver

Message ID 1650964728-175347-4-git-send-email-dh10.jung@samsung.com (mailing list archive)
State New, archived
Headers show
Series add xhci-exynos driver | expand

Commit Message

Jung Daehwan April 26, 2022, 9:18 a.m. UTC
It helps xhci-plat driver increase usability. Vendors could use functions
in xhci-plat mostly and use some overrides to do what they wants without
modifying xhci-plat driver.

Signed-off-by: Daehwan Jung <dh10.jung@samsung.com>
---
 drivers/usb/host/xhci-plat.c | 6 ++++++
 drivers/usb/host/xhci-plat.h | 1 +
 2 files changed, 7 insertions(+)

Comments

Greg Kroah-Hartman April 26, 2022, 10:20 a.m. UTC | #1
On Tue, Apr 26, 2022 at 06:18:46PM +0900, Daehwan Jung wrote:
> It helps xhci-plat driver increase usability. Vendors could use functions
> in xhci-plat mostly and use some overrides to do what they wants without
> modifying xhci-plat driver.
> 
> Signed-off-by: Daehwan Jung <dh10.jung@samsung.com>
> ---
>  drivers/usb/host/xhci-plat.c | 6 ++++++
>  drivers/usb/host/xhci-plat.h | 1 +
>  2 files changed, 7 insertions(+)
> 
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index a5881ff945a6..6efa3169bf69 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -173,6 +173,12 @@ static const struct of_device_id usb_xhci_of_match[] = {
>  MODULE_DEVICE_TABLE(of, usb_xhci_of_match);
>  #endif
>  
> +void xhci_plat_override_driver(const struct xhci_driver_overrides *xhci_vendor_overrides)
> +{
> +	xhci_init_driver(&xhci_plat_hc_driver, xhci_vendor_overrides);
> +}
> +EXPORT_SYMBOL(xhci_plat_override_driver);

EXPORT_SYMBOL_GPL() please.

thanks,

greg k-h
Jung Daehwan April 27, 2022, 9:07 a.m. UTC | #2
On Tue, Apr 26, 2022 at 12:20:07PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 26, 2022 at 06:18:46PM +0900, Daehwan Jung wrote:
> > It helps xhci-plat driver increase usability. Vendors could use functions
> > in xhci-plat mostly and use some overrides to do what they wants without
> > modifying xhci-plat driver.
> > 
> > Signed-off-by: Daehwan Jung <dh10.jung@samsung.com>
> > ---
> >  drivers/usb/host/xhci-plat.c | 6 ++++++
> >  drivers/usb/host/xhci-plat.h | 1 +
> >  2 files changed, 7 insertions(+)
> > 
> > diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> > index a5881ff945a6..6efa3169bf69 100644
> > --- a/drivers/usb/host/xhci-plat.c
> > +++ b/drivers/usb/host/xhci-plat.c
> > @@ -173,6 +173,12 @@ static const struct of_device_id usb_xhci_of_match[] = {
> >  MODULE_DEVICE_TABLE(of, usb_xhci_of_match);
> >  #endif
> >  
> > +void xhci_plat_override_driver(const struct xhci_driver_overrides *xhci_vendor_overrides)
> > +{
> > +	xhci_init_driver(&xhci_plat_hc_driver, xhci_vendor_overrides);
> > +}
> > +EXPORT_SYMBOL(xhci_plat_override_driver);
> 
> EXPORT_SYMBOL_GPL() please.
> 
> thanks,
> 
> greg k-h
> 

OK. I will modify it on next submission.

Best Regards,
Jung Daehwan
diff mbox series

Patch

diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index a5881ff945a6..6efa3169bf69 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers/usb/host/xhci-plat.c
@@ -173,6 +173,12 @@  static const struct of_device_id usb_xhci_of_match[] = {
 MODULE_DEVICE_TABLE(of, usb_xhci_of_match);
 #endif
 
+void xhci_plat_override_driver(const struct xhci_driver_overrides *xhci_vendor_overrides)
+{
+	xhci_init_driver(&xhci_plat_hc_driver, xhci_vendor_overrides);
+}
+EXPORT_SYMBOL(xhci_plat_override_driver);
+
 static struct xhci_plat_priv_overwrite xhci_plat_vendor_overwrite;
 
 int xhci_plat_register_vendor_ops(struct xhci_vendor_ops *vendor_ops)
diff --git a/drivers/usb/host/xhci-plat.h b/drivers/usb/host/xhci-plat.h
index 8c204f3234d8..455e0018d5e6 100644
--- a/drivers/usb/host/xhci-plat.h
+++ b/drivers/usb/host/xhci-plat.h
@@ -28,5 +28,6 @@  struct xhci_plat_priv_overwrite {
 };
 
 int xhci_plat_register_vendor_ops(struct xhci_vendor_ops *vendor_ops);
+void xhci_plat_override_driver(const struct xhci_driver_overrides *xhci_vendor_overrides);
 
 #endif	/* _XHCI_PLAT_H */