diff mbox

[20/20] usb: host: xhci: free priv outside of locked region

Message ID 20180416122930.15697-20-felipe.balbi@linux.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Felipe Balbi April 16, 2018, 12:29 p.m. UTC 
In case we have any errors, we can free_priv with locks released and
interrupts enabled.

Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
---
 drivers/usb/host/xhci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox

Patch

diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 0fab051f06fc..32aef7c9a677 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -1376,12 +1376,13 @@  static int xhci_urb_enqueue(struct usb_hcd *hcd, struct urb *urb, gfp_t mem_flag
 		ret = xhci_queue_isoc_tx(xhci, GFP_ATOMIC, urb,
 				slot_id, ep_index);
 	}
+	spin_unlock_irqrestore(&xhci->lock, flags);
 
 	if (ret) {
 		xhci_urb_free_priv(urb_priv);
 		urb->hcpriv = NULL;
 	}
-	spin_unlock_irqrestore(&xhci->lock, flags);
+
 	return ret;
 }