From patchwork Mon Apr 16 12:29:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 10342873 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 883C5601D7 for ; Mon, 16 Apr 2018 12:30:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5EF1228737 for ; Mon, 16 Apr 2018 12:30:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5D88A2873E; Mon, 16 Apr 2018 12:30:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D670D28737 for ; Mon, 16 Apr 2018 12:30:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754358AbeDPMan (ORCPT ); Mon, 16 Apr 2018 08:30:43 -0400 Received: from mga14.intel.com ([192.55.52.115]:52814 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754577AbeDPMaj (ORCPT ); Mon, 16 Apr 2018 08:30:39 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2018 05:30:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,459,1517904000"; d="scan'208";a="37721973" Received: from pipin.fi.intel.com (HELO localhost) ([10.237.68.37]) by fmsmga002.fm.intel.com with ESMTP; 16 Apr 2018 05:30:38 -0700 From: Felipe Balbi To: Mathias Nyman Cc: Linux USB , Felipe Balbi Subject: [PATCH 06/20] usb: host: xhci: reorder variable declarations Date: Mon, 16 Apr 2018 15:29:16 +0300 Message-Id: <20180416122930.15697-6-felipe.balbi@linux.intel.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180416122930.15697-1-felipe.balbi@linux.intel.com> References: <20180416122930.15697-1-felipe.balbi@linux.intel.com> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Cleanup only, no functional changes. While at that, remove the initialization of ret which is now unnecessary. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index f2733f717568..eec9e0c0b7c9 100644 --- a/drivers/usb/host/xhci.c +++ b/drivers/usb/host/xhci.c @@ -1303,12 +1303,13 @@ static int xhci_num_tds_for_urb(struct urb *urb) static int xhci_urb_enqueue(struct usb_hcd *hcd, struct urb *urb, gfp_t mem_flags) { struct xhci_hcd *xhci = hcd_to_xhci(hcd); + struct urb_priv *urb_priv; unsigned long flags; - int ret = 0; - unsigned int slot_id, ep_index; unsigned int *ep_state; - struct urb_priv *urb_priv; + unsigned int ep_index; + unsigned int slot_id; int num_tds; + int ret; if (!urb || xhci_check_args(hcd, urb->dev, urb->ep, true, true, __func__) <= 0)