From patchwork Tue Apr 24 13:17:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 10359859 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D0654601BE for ; Tue, 24 Apr 2018 13:30:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C283828DE9 for ; Tue, 24 Apr 2018 13:30:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B78D728DF8; Tue, 24 Apr 2018 13:30:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 62D0F28DF4 for ; Tue, 24 Apr 2018 13:30:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933977AbeDXNSF (ORCPT ); Tue, 24 Apr 2018 09:18:05 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35153 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933839AbeDXNSD (ORCPT ); Tue, 24 Apr 2018 09:18:03 -0400 Received: by mail-wm0-f67.google.com with SMTP id o78so808377wmg.0; Tue, 24 Apr 2018 06:18:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=HRNZeUgGXiVdSLzWJelm0hZLWq6WQWrvD8IUB7RUr0E=; b=uFS95n6JTBm5p0APdn8EuDC2bBTQF7K0cvcAb/HrTi2uwhS/K8QRShRQiIgrBam1dW mQ+NIC9MTtXNQW78ty5WnBVkx1tcy7T7p7FHO/zsipEBlewZ1BjCIKKEa66/HL7k50SD cA4MIeW1Q2miYMUAuSbpXh8UxMY8KqbpfbjZ2fkHLfXeSnc94ZdqVRzRMKNwGDU6M1U4 J1TCSCzOncaOLod2T/aYLOL9UMLD9X3Pj8m/2T6nHQQeJIdgDwgguL+u6jP1PKX7E+8n YUZVTYxd859CohmXp2DUQ8ShQbiEZ6NLt+OO8FSQRJQKeAKzQsXOctYlZoLv5Eu8zJII MP/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=HRNZeUgGXiVdSLzWJelm0hZLWq6WQWrvD8IUB7RUr0E=; b=LBgHoFgrfobFvxYiCQZQXr/9Lj/5K72ouUyeGJzFzmnk/QZooylKzjvn2BjYOpXbRR +qZwClJ9BA7TfitPx9aWofLs/y07xPgTB/ZN1VP+y9xuw2sbcaQWrLdId5NS1hkmaHUz 5z2HU7woXl/paAYYfkSZlI2VLDs7uAljUAJCDiEddRKM6Fnu9ztG9uDI+o157vYDHSmM VyS1EWqYp8uzSnMOL0aipwWYxeUn7sjcwyZg6eMYyw13Zq00mwlkcaWV2jG2LWNNwnQ0 ME8e36HnCOWAg+UYaNyqOksQjuo3yTDPa7UCiH6p5EmgLrYT1dhmlJX+WM6DVPXn5tJX g6mg== X-Gm-Message-State: ALQs6tB//E8Yxn+lI/RSx6f6KlcQa5ZoMFgjiPk75iMy3+AVRclTRoAR /z9pKhRTmpAJaca64cHiyM5cFHBOAf4= X-Google-Smtp-Source: AIpwx49nkKBrPFJwjKOVtzNdBFxh6d9T6MN2ezrrn8AzGOCgwq9C4W0LyJfUmVL/VoqC8UrwksNKGg== X-Received: by 10.80.139.249 with SMTP id n54mr33322730edn.216.1524575881708; Tue, 24 Apr 2018 06:18:01 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:40e7:cd00:5113:f351:d61c:108c]) by smtp.gmail.com with ESMTPSA id q6sm8554689edh.48.2018.04.24.06.18.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Apr 2018 06:18:01 -0700 (PDT) From: Luc Van Oostenryck To: linux-kernel@vger.kernel.org Cc: Luc Van Oostenryck , "David S. Miller" , "Gustavo A. R. Silva" , Arvind Yadav , Johannes Berg , Alexander Kappner , linux-usb@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH] usbnet: ipheth: fix ipheth_tx()'s return type Date: Tue, 24 Apr 2018 15:17:58 +0200 Message-Id: <20180424131800.4862-1-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck --- drivers/net/usb/ipheth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/ipheth.c b/drivers/net/usb/ipheth.c index 7275761a1..53eab6fb9 100644 --- a/drivers/net/usb/ipheth.c +++ b/drivers/net/usb/ipheth.c @@ -413,7 +413,7 @@ static int ipheth_close(struct net_device *net) return 0; } -static int ipheth_tx(struct sk_buff *skb, struct net_device *net) +static netdev_tx_t ipheth_tx(struct sk_buff *skb, struct net_device *net) { struct ipheth_device *dev = netdev_priv(net); struct usb_device *udev = dev->udev;