| Message ID | 20180701122720.27315-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/01/2018 05:27 AM, Hans de Goede wrote: > The set_current_limit tcpm_dev callback is optional and the tcpm core > will already log the passed in values, so there is no need to have an > empty implementation of this. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/usb/typec/fusb302/fusb302.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/drivers/usb/typec/fusb302/fusb302.c b/drivers/usb/typec/fusb302/fusb302.c > index 1e68da10bf17..82bed9810be6 100644 > --- a/drivers/usb/typec/fusb302/fusb302.c > +++ b/drivers/usb/typec/fusb302/fusb302.c > @@ -864,17 +864,6 @@ static int tcpm_set_vbus(struct tcpc_dev *dev, bool on, bool charge) > return ret; > } > > -static int tcpm_set_current_limit(struct tcpc_dev *dev, u32 max_ma, u32 mv) > -{ > - struct fusb302_chip *chip = container_of(dev, struct fusb302_chip, > - tcpc_dev); > - > - fusb302_log(chip, "current limit: %d ma, %d mv (not implemented)", > - max_ma, mv); > - > - return 0; > -} > - > static int fusb302_pd_tx_flush(struct fusb302_chip *chip) > { > return fusb302_i2c_set_bits(chip, FUSB_REG_CONTROL0, > @@ -1213,7 +1202,6 @@ static void init_tcpc_dev(struct tcpc_dev *fusb302_tcpc_dev) > fusb302_tcpc_dev->set_polarity = tcpm_set_polarity; > fusb302_tcpc_dev->set_vconn = tcpm_set_vconn; > fusb302_tcpc_dev->set_vbus = tcpm_set_vbus; > - fusb302_tcpc_dev->set_current_limit = tcpm_set_current_limit; > fusb302_tcpc_dev->set_pd_rx = tcpm_set_pd_rx; > fusb302_tcpc_dev->set_roles = tcpm_set_roles; > fusb302_tcpc_dev->start_drp_toggling = tcpm_start_drp_toggling; > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/usb/typec/fusb302/fusb302.c b/drivers/usb/typec/fusb302/fusb302.c index 1e68da10bf17..82bed9810be6 100644 --- a/drivers/usb/typec/fusb302/fusb302.c +++ b/drivers/usb/typec/fusb302/fusb302.c @@ -864,17 +864,6 @@ static int tcpm_set_vbus(struct tcpc_dev *dev, bool on, bool charge) return ret; } -static int tcpm_set_current_limit(struct tcpc_dev *dev, u32 max_ma, u32 mv) -{ - struct fusb302_chip *chip = container_of(dev, struct fusb302_chip, - tcpc_dev); - - fusb302_log(chip, "current limit: %d ma, %d mv (not implemented)", - max_ma, mv); - - return 0; -} - static int fusb302_pd_tx_flush(struct fusb302_chip *chip) { return fusb302_i2c_set_bits(chip, FUSB_REG_CONTROL0, @@ -1213,7 +1202,6 @@ static void init_tcpc_dev(struct tcpc_dev *fusb302_tcpc_dev) fusb302_tcpc_dev->set_polarity = tcpm_set_polarity; fusb302_tcpc_dev->set_vconn = tcpm_set_vconn; fusb302_tcpc_dev->set_vbus = tcpm_set_vbus; - fusb302_tcpc_dev->set_current_limit = tcpm_set_current_limit; fusb302_tcpc_dev->set_pd_rx = tcpm_set_pd_rx; fusb302_tcpc_dev->set_roles = tcpm_set_roles; fusb302_tcpc_dev->start_drp_toggling = tcpm_start_drp_toggling;
The set_current_limit tcpm_dev callback is optional and the tcpm core will already log the passed in values, so there is no need to have an empty implementation of this. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/usb/typec/fusb302/fusb302.c | 12 ------------ 1 file changed, 12 deletions(-)