From patchwork Fri Jul 6 16:21:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10512099 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3FBDF603D7 for ; Fri, 6 Jul 2018 16:23:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3118428722 for ; Fri, 6 Jul 2018 16:23:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 252462872E; Fri, 6 Jul 2018 16:23:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BFC2128722 for ; Fri, 6 Jul 2018 16:23:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933405AbeGFQXP (ORCPT ); Fri, 6 Jul 2018 12:23:15 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:35551 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933510AbeGFQWS (ORCPT ); Fri, 6 Jul 2018 12:22:18 -0400 Received: by mail-pf0-f193.google.com with SMTP id q7-v6so7732177pff.2 for ; Fri, 06 Jul 2018 09:22:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vDIrkkGnKtuUhTna2+qlhQEY4Z80qaFM3p58k9IlUjk=; b=aSb6/6Xv00RMk23atV4Y1QrakB6ui8SXO1RBFSwB+8lVGTx0GmT/dhAdUO18FOwE3m QGmfbfI42bGdeWpEtGXjhsfb3B6A1XXeetK7Wjwl0mzmdOsjshbgp1pAo0hYA7O0aPFP WK091JrfzV0sGMHd+e+hqvK6nDWf11ICt30EM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vDIrkkGnKtuUhTna2+qlhQEY4Z80qaFM3p58k9IlUjk=; b=KVDiU2bFfHw91Y00MA3oXlxAespxz5BX0LyvvoA9PKICog3JQ08shG/v0TVJ2SUisD UXcbcDPkngtolcF2fQUjQfhA1iMbfjPmbNxDuDPMC8xDcKfccKRR3sjSWoGP6vxaC5xZ G/ihoJrsJRLv1ahl+dMU/KBy/pB5w4JhyZWMhAw7HjuZefo7j273mW3a0Fh19oWsekO+ 4gS+8RDreka0ThL9MpnlxiRtv4POnp1bpHCjRmmbmotCVP3GaKZx7HmMJa7OZxfQEwPl azSpeVOQlPgmk7zpBs3jyalDP6TIrJ7CHLpOCa1YouwJsJozKpvEWQCeXrjxEfwNQBbe if7Q== X-Gm-Message-State: APt69E30sl7m1ZeF3qvLobGVSPuLLupXBIHRGWu6OGTbEASIpNUCqjRr 3NikKfhg8e5xeMPjZ252o66Eyw== X-Google-Smtp-Source: AAOMgpeJJJ91kGHC9WvAcVWdRN34mcVc7HuQ8hcq0e3cpyQvemM0tihfuGkmkalLcP16VoysVI7OGQ== X-Received: by 2002:a63:6441:: with SMTP id y62-v6mr3854612pgb.240.1530894137941; Fri, 06 Jul 2018 09:22:17 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:0:1000:1501:38e4:86fe:ec0c:4007]) by smtp.gmail.com with ESMTPSA id e125-v6sm8926688pfe.52.2018.07.06.09.22.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Jul 2018 09:22:17 -0700 (PDT) From: Douglas Anderson To: hminas@synopsys.com, gregkh@linuxfoundation.org Cc: Jerome Brunet , Zhangfei Gao , Stephen Warren , Bruno Herrera , Douglas Anderson , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFT PATCH 1/4] usb: dwc2: Turn on uframe_sched on "bcm" platforms Date: Fri, 6 Jul 2018 09:21:51 -0700 Message-Id: <20180706162154.196345-2-dianders@chromium.org> X-Mailer: git-send-email 2.18.0.399.gad0ab374a1-goog In-Reply-To: <20180706162154.196345-1-dianders@chromium.org> References: <20180706162154.196345-1-dianders@chromium.org> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There's no reason to have the uframe scheduler off on dwc2. Running with uframe_sched = False is equivalent to saying "I don't want to run the correct code, I want to run the old and incorrect code". The uframe scheduler has been off on Broadcom since commit 58b179dcf28c ("staging: dwc2: disable uframe_sched on the bcm2835"). Since then there have been many many improvements, notably the commit 9f9f09b048f5 ("usb: dwc2: host: Totally redo the microframe scheduler") Presumably if everyone is good w/ the uframe_sched turned back on we can kill all the old and crufty non-uframe sched code. Signed-off-by: Douglas Anderson --- drivers/usb/dwc2/params.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c index af075d4da895..14b8742e62fa 100644 --- a/drivers/usb/dwc2/params.c +++ b/drivers/usb/dwc2/params.c @@ -47,7 +47,6 @@ static void dwc2_set_bcm_params(struct dwc2_hsotg *hsotg) p->max_transfer_size = 65535; p->max_packet_count = 511; p->ahbcfg = 0x10; - p->uframe_sched = false; } static void dwc2_set_his_params(struct dwc2_hsotg *hsotg)