diff mbox

[2/2] USB: iuu_phoenix: drop redundant input-speed re-encoding

Message ID 20180716115156.29106-2-johan@kernel.org (mailing list archive)
State New, archived
Headers show

Commit Message

Johan Hovold July 16, 2018, 11:51 a.m. UTC
Drop redundant input-speed re-encoding at every open(). The output and
input speeds are initialised to the same value and are kept in sync on
termios updates.

Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/usb/serial/iuu_phoenix.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Greg KH July 16, 2018, 11:56 a.m. UTC | #1
On Mon, Jul 16, 2018 at 01:51:56PM +0200, Johan Hovold wrote:
> Drop redundant input-speed re-encoding at every open(). The output and
> input speeds are initialised to the same value and are kept in sync on
> termios updates.
> 
> Signed-off-by: Johan Hovold <johan@kernel.org>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Johan Hovold July 16, 2018, 12:14 p.m. UTC | #2
On Mon, Jul 16, 2018 at 01:56:46PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Jul 16, 2018 at 01:51:56PM +0200, Johan Hovold wrote:
> > Drop redundant input-speed re-encoding at every open(). The output and
> > input speeds are initialised to the same value and are kept in sync on
> > termios updates.
> > 
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> 
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Thanks for reviewing. Both now applied.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/usb/serial/iuu_phoenix.c b/drivers/usb/serial/iuu_phoenix.c
index 87c8dd064205..449e89db9cea 100644
--- a/drivers/usb/serial/iuu_phoenix.c
+++ b/drivers/usb/serial/iuu_phoenix.c
@@ -962,9 +962,6 @@  static int iuu_open(struct tty_struct *tty, struct usb_serial_port *port)
 	struct iuu_private *priv = usb_get_serial_port_data(port);
 
 	baud = tty->termios.c_ospeed;
-	tty->termios.c_ispeed = baud;
-	/* Re-encode speed */
-	tty_encode_baud_rate(tty, baud, baud);
 
 	dev_dbg(dev, "%s - baud %d\n", __func__, baud);
 	usb_clear_halt(serial->dev, port->write_urb->pipe);