From patchwork Thu Jul 26 20:07:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10546401 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 00AA1112E for ; Thu, 26 Jul 2018 20:08:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EBA122BCA3 for ; Thu, 26 Jul 2018 20:08:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DFBD62BCAD; Thu, 26 Jul 2018 20:08:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 80F1A2BCA3 for ; Thu, 26 Jul 2018 20:08:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731760AbeGZV0k (ORCPT ); Thu, 26 Jul 2018 17:26:40 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:34992 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731557AbeGZV02 (ORCPT ); Thu, 26 Jul 2018 17:26:28 -0400 Received: by mail-pf1-f196.google.com with SMTP id q7-v6so932151pff.2 for ; Thu, 26 Jul 2018 13:08:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=poRASEvlVBUAcfLB4RhlwSj/p7/jDuj4PF7wn26CH6s=; b=EuZ996MDr/awcYYi/XmOHQH60XNrvktL6KUpom+u4h04Llj4H+kWvXsF4G83MBGwJA FLASRPQBPuyYwGxHe48PcaQys8VTNtnBDzUPyxGg44JBQgIt8deE5Q8DIG7fGZhZKsMR vEbHJEa2w4NSqRv5TFhdj0LqYKIYEnZb5Yb8Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=poRASEvlVBUAcfLB4RhlwSj/p7/jDuj4PF7wn26CH6s=; b=mk5LbpJD8tXwgBRpWESITUpd8Cxl5frquJMsqVavNKf4i7ApHdAIzL1k3LdjbAJx0Y V9RynHtNxn1V3OGefH0zJ8R5K7/DQBl0ro1ezx0alfwLZ2t1MWT0AV+mB7Yklo0797uS HF4D2jy5XrdWJpf66VFL0aM9S3Pf8gAlBxiZzWeRL+rhy4DLFXwiz0p7KoHRDBeWe867 SdnV1RiEcmzxBxeVJsAh6ZdGDJzsOR3VgMWGhPsFFww8Jt98Qw4I7AKdqsBwrSB5NidR +ujVHor7C0JkzBV+pZxJCkjIC1GWrvhsmHEIBUTYH/CFMgGZVtQK1wIFPyFiwBEVjqgS xdcA== X-Gm-Message-State: AOUpUlH0HQCfvbelfBObzeFp05OY4YmlPJ8jzN9G7NckHDXOSfjcsbC7 wabC2Da7cvQj9EFSzB972NjALA== X-Google-Smtp-Source: AAOMgpeTZUEvqBv0EEh4ci8/3umHRH8aF6yjX+RHRA2ViJhGz627ApLDNUterAuw1dXDa3gOx2rt8A== X-Received: by 2002:a62:571b:: with SMTP id l27-v6mr3539635pfb.29.1532635682969; Thu, 26 Jul 2018 13:08:02 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:0:1000:1501:38e4:86fe:ec0c:4007]) by smtp.gmail.com with ESMTPSA id u11-v6sm5784169pfd.117.2018.07.26.13.08.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Jul 2018 13:08:02 -0700 (PDT) From: Douglas Anderson To: balbi@kernel.org, hminas@synopsys.com, gregkh@linuxfoundation.org Cc: stefan.wahren@i2se.com, grigor.tovmasyan@synopsys.com, Bruno Herrera , Zhangfei Gao , john.stultz@linaro.org, Stephen Warren , Jerome Brunet , Douglas Anderson , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [REPOST PATCH 3/4] usb: dwc2: Turn on uframe_sched on "amlogic" platforms Date: Thu, 26 Jul 2018 13:07:29 -0700 Message-Id: <20180726200730.18290-4-dianders@chromium.org> X-Mailer: git-send-email 2.18.0.345.g5c9ce644c3-goog In-Reply-To: <20180726200730.18290-1-dianders@chromium.org> References: <20180726200730.18290-1-dianders@chromium.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There's no reason to have the uframe scheduler off on dwc2. Running with uframe_sched = False is equivalent to saying "I don't want to run the correct code, I want to run the old and incorrect code". The uframe scheduler has been off on Amlogic since commit f94310ac076e ("usb: dwc2: add support for Meson8b and GXBB SoCs"). While this was after most of the recent improvements, notably the commit 9f9f09b048f5 ("usb: dwc2: host: Totally redo the microframe scheduler"), presumably the parameters were copied from another platform and the uframe scheduler wasn't tried. Presumably if everyone is good w/ the uframe_sched turned back on we can kill all the old and crufty non-uframe sched code. Signed-off-by: Douglas Anderson Reviewed-by: Minas Harutyunyan --- drivers/usb/dwc2/params.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c index db97bb16ecc4..93380f7c32b4 100644 --- a/drivers/usb/dwc2/params.c +++ b/drivers/usb/dwc2/params.c @@ -110,7 +110,6 @@ static void dwc2_set_amlogic_params(struct dwc2_hsotg *hsotg) p->phy_type = DWC2_PHY_TYPE_PARAM_UTMI; p->ahbcfg = GAHBCFG_HBSTLEN_INCR8 << GAHBCFG_HBSTLEN_SHIFT; - p->uframe_sched = false; } static void dwc2_set_amcc_params(struct dwc2_hsotg *hsotg)