| Message ID | 20180808220155.23636-2-vz@mleia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] usb storage: group dependent USB storage Kconfig entries together | expand |
On Do, 2018-08-09 at 01:01 +0300, Vladimir Zapolskiy wrote: > Because USB_STORAGE build symbol strictly depends on SCSI build > symbol, there is no need to specify it again for USB_UAS and > USB_STORAGE_ENE_UB6250 build options. [..] > config USB_UAS > tristate "USB Attached SCSI" > - depends on SCSI > help > The USB Attached SCSI protocol is supported by some USB > storage devices. It permits higher performance by supporting Hi, I am sorry, but this is wrong. You can build and use UAS without old style storage support. I do not recommend that you do so, but in theory it is possible. And UAS very much depends on storage. Regards Oliver Nacked-by: Oliver Neukum <oneukum@suse.com> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Oliver, On 08/09/2018 10:38 AM, Oliver Neukum wrote: > On Do, 2018-08-09 at 01:01 +0300, Vladimir Zapolskiy wrote: >> Because USB_STORAGE build symbol strictly depends on SCSI build >> symbol, there is no need to specify it again for USB_UAS and >> USB_STORAGE_ENE_UB6250 build options. > > [..] > >> config USB_UAS >> tristate "USB Attached SCSI" >> - depends on SCSI >> help >> The USB Attached SCSI protocol is supported by some USB >> storage devices. It permits higher performance by supporting > > Hi, > > I am sorry, but this is wrong. You can build and use UAS without can you please elaborate what is wrong exactly. The change is non-functional. -- Best wishes, Vladimir > old style storage support. I do not recommend that you do so, > but in theory it is possible. > And UAS very much depends on storage. > > Regards > Oliver > > Nacked-by: Oliver Neukum <oneukum@suse.com> > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Do, 2018-08-09 at 10:50 +0300, Vladimir Zapolskiy wrote: > Hi Oliver, > > On 08/09/2018 10:38 AM, Oliver Neukum wrote: > > On Do, 2018-08-09 at 01:01 +0300, Vladimir Zapolskiy wrote: > > > Because USB_STORAGE build symbol strictly depends on SCSI build > > > symbol, there is no need to specify it again for USB_UAS and > > > USB_STORAGE_ENE_UB6250 build options. > > > > [..] > > > > > config USB_UAS > > > tristate "USB Attached SCSI" > > > - depends on SCSI > > > help > > > The USB Attached SCSI protocol is supported by some USB > > > storage devices. It permits higher performance by supporting > > > > Hi, > > > > I am sorry, but this is wrong. You can build and use UAS without > > can you please elaborate what is wrong exactly. > > The change is non-functional. Hi, as far as I can tell you are introducing an implicit dependency of CONFIG_USB_UAS on CONFIG_USB_STORAGE. Now, firstly implicit references are bad anyway, secondly in this case it is wrong. Uas works without usb-storage. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Aug 09, 2018 at 09:38:40AM +0200, Oliver Neukum wrote: > On Do, 2018-08-09 at 01:01 +0300, Vladimir Zapolskiy wrote: > > Because USB_STORAGE build symbol strictly depends on SCSI build > > symbol, there is no need to specify it again for USB_UAS and > > USB_STORAGE_ENE_UB6250 build options. > > [..] > > > config USB_UAS > > tristate "USB Attached SCSI" > > - depends on SCSI > > help > > The USB Attached SCSI protocol is supported by some USB > > storage devices. It permits higher performance by supporting > > Hi, > > I am sorry, but this is wrong. You can build and use UAS without > old style storage support. I do not recommend that you do so, > but in theory it is possible. > And UAS very much depends on storage. But today UAS depends on SCSI and USB_STORAGE, so if this is true, it's not very obvious :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Do, 2018-08-09 at 11:21 +0200, Greg Kroah-Hartman wrote: > On Thu, Aug 09, 2018 at 09:38:40AM +0200, Oliver Neukum wrote: > > On Do, 2018-08-09 at 01:01 +0300, Vladimir Zapolskiy wrote: > > > Because USB_STORAGE build symbol strictly depends on SCSI build > > > symbol, there is no need to specify it again for USB_UAS and > > > USB_STORAGE_ENE_UB6250 build options. > > > > [..] > > > > > config USB_UAS > > > tristate "USB Attached SCSI" > > > - depends on SCSI > > > help > > > The USB Attached SCSI protocol is supported by some USB > > > storage devices. It permits higher performance by supporting > > > > Hi, > > > > I am sorry, but this is wrong. You can build and use UAS without > > old style storage support. I do not recommend that you do so, > > but in theory it is possible. > > And UAS very much depends on storage. > > But today UAS depends on SCSI and USB_STORAGE, so if this is true, it's > not very obvious :) Hi, yes, this is an issue. Nevertheless UAS depends on SCSI and this dependency better stay. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/usb/storage/Kconfig b/drivers/usb/storage/Kconfig index 0aef832d3be6..7db5b28fbf0c 100644 --- a/drivers/usb/storage/Kconfig +++ b/drivers/usb/storage/Kconfig @@ -176,21 +176,15 @@ config USB_STORAGE_CYPRESS_ATACB config USB_STORAGE_ENE_UB6250 tristate "USB ENE card reader support" - depends on SCSI ---help--- Say Y here if you wish to control a ENE SD/MS Card reader. Note that this driver does not support SM cards. - This option depends on 'SCSI' support being enabled, but you - probably also need 'SCSI device support: SCSI disk support' - (BLK_DEV_SD) for most USB storage devices. - To compile this driver as a module, choose M here: the module will be called ums-eneub6250. config USB_UAS tristate "USB Attached SCSI" - depends on SCSI help The USB Attached SCSI protocol is supported by some USB storage devices. It permits higher performance by supporting
Because USB_STORAGE build symbol strictly depends on SCSI build symbol, there is no need to specify it again for USB_UAS and USB_STORAGE_ENE_UB6250 build options. In addition USB_STORAGE_ENE_UB6250 entry description repeats a note about SCSI dependency from the parent USB_STORAGE entry description, hence the change removes this duplication. Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> --- drivers/usb/storage/Kconfig | 6 ------ 1 file changed, 6 deletions(-)