From patchwork Mon Sep 24 20:54:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 10612849 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5052215A6 for ; Mon, 24 Sep 2018 20:56:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 449C229807 for ; Mon, 24 Sep 2018 20:56:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 42B3F2A5AB; Mon, 24 Sep 2018 20:56:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F304829807 for ; Mon, 24 Sep 2018 20:56:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728626AbeIYDAI (ORCPT ); Mon, 24 Sep 2018 23:00:08 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:34288 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728241AbeIYC71 (ORCPT ); Mon, 24 Sep 2018 22:59:27 -0400 Received: by mail-pg1-f194.google.com with SMTP id d19-v6so9812744pgv.1; Mon, 24 Sep 2018 13:55:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=haEHP1Iz78Fw98J7Yy0wNUApgo7Zm5Zh0aJ5xbSU/Us=; b=Qmt7huEA0NbU+qF3631L2DlKQw8yU2+4ANxgNG2MF0n0dslJV4c5DHAdmVenA8XjKW gHBDYg7DJgOXzMW2rNXjbHDrA95132ijtMpzLDJCxTYgBBTZPeZz2NQebAJ5CPjtShtJ NysVk0iHut7VoHiTsIfuQySJ4sT4C/VEqr5aWHfVoBj2iVKUaQPLqlBM8dgndrwvCKxQ aubSAPaFY9vC6D1SFhQQrQBI9+ZPC0deSV64BzZLmYWqzsmBJM/p4r7iuxNQC0Ax38Gv UNzJ64NBdmJi2ZjEhvxLua+lEbVLOAOoQ3H4wJYRj1EOWQ50yjaH1Tu7iACgz9eFAsMF Vl6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=haEHP1Iz78Fw98J7Yy0wNUApgo7Zm5Zh0aJ5xbSU/Us=; b=Ov0/4HGNKf6xWL3MQIth5ad1YdzTG8sbVQ/0HiisBiZDuHOKIduz4C2kFk4I4zq8yW 4mGOY7P690ciwURXm+qNxD2WDU423Sjj80cM+8vwz35E8LRcBp9tOJh27MjJS3i+/ab5 eLI/1EsNewLMn19V0EMCyzOs4o72OJXTGw1dOHsIx2S2pwqa5rKfG5aPUP/rkwJLKZXI W+icNUu1D6aM/j1SHNQqv8yR9QUTHMqhpeKb3tdS92D8K+eUFEX3Z/0qRRj03S52L6aS kAu8sD0HfiRTCjqts/NPEoLjtkSb0RgssvN3TWpfzKqzrpJxDC8pCbrijd08hCR0QY0d eyMg== X-Gm-Message-State: ABuFfoi6itKZdpdvq7yKuBU3w+b/yLrE7hvEBaeAw2JKSRFSmGjUF6bJ frGUZibTYamMkh5UMklEHJKbGD4a X-Google-Smtp-Source: ACcGV61Sdk6257xCESRmPgZt97TacEp/Q/7WzzuKqe3Lgg1O+eW/+cnHx5RqykijDf1vCbuyg7lUKA== X-Received: by 2002:a63:24c:: with SMTP id 73-v6mr466823pgc.252.1537822523099; Mon, 24 Sep 2018 13:55:23 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.250]) by smtp.gmail.com with ESMTPSA id b62-v6sm260160pfm.183.2018.09.24.13.55.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Sep 2018 13:55:21 -0700 (PDT) From: Florian Fainelli To: netdev@vger.kernel.org Cc: Florian Fainelli , "David S. Miller" , Woojung Huh , Microchip Linux Driver Support , Steve Glendinning , Kees Cook , Alexander Kurz , Hayes Wang , Kai-Heng Feng , Grant Grundler , zhong jiang , Sebastian Andrzej Siewior , Ran Wang , Eric Dumazet , linux-usb@vger.kernel.org (open list:USB NETWORKING DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH net 3/7] lan78xx: Check for supported Wake-on-LAN modes Date: Mon, 24 Sep 2018 13:54:16 -0700 Message-Id: <20180924205420.31309-4-f.fainelli@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180924205420.31309-1-f.fainelli@gmail.com> References: <20180924205420.31309-1-f.fainelli@gmail.com> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver supports a fair amount of Wake-on-LAN modes, but is not checking that the user specified one that is supported. Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver") Signed-off-by: Florian Fainelli --- drivers/net/usb/lan78xx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index a9991c5f4736..e0a588d1b8e6 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -1415,6 +1415,9 @@ static int lan78xx_set_wol(struct net_device *netdev, if (wol->wolopts & WAKE_ARP) pdata->wol |= WAKE_ARP; + if (pdata->wol == 0) + return -EINVAL; + device_set_wakeup_enable(&dev->udev->dev, (bool)wol->wolopts); phy_ethtool_set_wol(netdev->phydev, wol);