From patchwork Wed Nov 7 20:40:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 10673053 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 267FA13A4 for ; Wed, 7 Nov 2018 20:41:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1680F2D0E6 for ; Wed, 7 Nov 2018 20:41:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0AACC2D120; Wed, 7 Nov 2018 20:41:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ACF332D0E6 for ; Wed, 7 Nov 2018 20:41:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726807AbeKHGMy (ORCPT ); Thu, 8 Nov 2018 01:12:54 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:33732 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726722AbeKHGMy (ORCPT ); Thu, 8 Nov 2018 01:12:54 -0500 Received: by mail-pl1-f196.google.com with SMTP id w22-v6so5067704plk.0 for ; Wed, 07 Nov 2018 12:40:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=JR0Rfw9fH1+7vyvtLI1tXlAk1pXgLP73l2sRMfZ7/0w=; b=jue8aUJBNKn76Vnp3UeuEaSa+jeaznf7He/qRHEXSHSRfe5Oe7Vr8HNrxZQX1IIGlI bKIiCYJyNPezy7FvFGaWPHm3+mlDjJwCd0GfCL1bUrmhD5HQXOlIPcaEjlpAhBbC5Pgd FB9uGMd4B/JGMSzL7L9b0oAM4E2s4YOiBnElA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=JR0Rfw9fH1+7vyvtLI1tXlAk1pXgLP73l2sRMfZ7/0w=; b=I8WCWolmhIcsRaK6FKYZSurt+RIrUZNo5m6jp+uilB9GqjVnZdzJxDVD5VpS3ZztMs zNQOq/ciAzYcRsTWXAPzxlc6fpZBSui49SOTyB3Q3BHah0DUU9nnOiOZjvMO/Wc0BPc+ EWbDS/e2IgP0xqmtW7kcVsQdQb5t2OFhUhGCqScklybsC8POu9bEv9GRvGHvQn5zwfwZ kSJUE2VU8vKvg+TgmhLWvvAbJHx/LVGBAj0iI/p9xuSaCHLZ0V/hQLJpq2YrbNAVdCqH HoJY4CePcVC5Song8YJQniAKubdrvXQ3jqiIpyij+JfrQFtIeRBo0QdUM5ZIFPLun1JU nEJg== X-Gm-Message-State: AGRZ1gLS+vgfSzvb8GxdWSQGuhdD8kvqVJEwkK63Hp4SfSvyj3MzGxC4 397XFr+HBPZ4SxVemb5Gi3oyag== X-Google-Smtp-Source: AJdET5fIVbxEkRLhzffCUIsMGefvO/n1cKliRax/rVZnNRM8jXBf4rZXVm3Y5DZGEM0wBvmAaj2YgQ== X-Received: by 2002:a17:902:da8:: with SMTP id 37-v6mr1840319plv.12.1541623251292; Wed, 07 Nov 2018 12:40:51 -0800 (PST) Received: from smtp.gmail.com ([2620:15c:202:1:299d:6b87:5478:d28a]) by smtp.gmail.com with ESMTPSA id m10-v6sm2118013pfg.180.2018.11.07.12.40.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Nov 2018 12:40:37 -0800 (PST) From: Brian Norris To: Felipe Balbi Cc: linux-usb@vger.kernel.org, , Brian Norris Subject: [PATCH] usb: dwc3: don't log probe deferrals; but do log other error codes Date: Wed, 7 Nov 2018 12:40:29 -0800 Message-Id: <20181107204029.88466-1-briannorris@chromium.org> X-Mailer: git-send-email 2.19.1.930.g4563a0d9d0-goog MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It's not very useful to repeat a bunch of probe deferral errors. And it's also not very useful to log "failed" without telling the error code. Signed-off-by: Brian Norris Tested-by: Enric Balletbo i Serra --- drivers/usb/dwc3/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 88c80fcc39f5..1ef346ba6a02 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -1482,7 +1482,8 @@ static int dwc3_probe(struct platform_device *pdev) ret = dwc3_core_init(dwc); if (ret) { - dev_err(dev, "failed to initialize core\n"); + if (ret != -EPROBE_DEFER) + dev_err(dev, "failed to initialize core: %d\n", ret); goto err4; }