From patchwork Thu Nov 29 03:16:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hsin-Yi Wang X-Patchwork-Id: 10703855 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4EF6917F0 for ; Thu, 29 Nov 2018 03:16:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3AC372E7C8 for ; Thu, 29 Nov 2018 03:16:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2B7FC2E80A; Thu, 29 Nov 2018 03:16:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CDF292E7C8 for ; Thu, 29 Nov 2018 03:16:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727193AbeK2OUY (ORCPT ); Thu, 29 Nov 2018 09:20:24 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:37182 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727120AbeK2OUY (ORCPT ); Thu, 29 Nov 2018 09:20:24 -0500 Received: by mail-pl1-f193.google.com with SMTP id b5so285257plr.4 for ; Wed, 28 Nov 2018 19:16:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FfEaTpIexbfNgh3WA2OcVxQfootPIVWg5nn9CpgLyKI=; b=cF8sPaPd3LzOZgGC0TgpjarH3LcnuzT+OH+UW20hnr3dVGkCPvaGO7/TCjUNNB7a0F N0s0Oi+VlRBCApTveTJH30/2eAabgKxm0SqgkljgpnEyDUG256ZTCii9XJSHlYEnQ4yW es9QzxAgQtq1cF5DrMsMRzok4CXaSXEEKZ3JQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FfEaTpIexbfNgh3WA2OcVxQfootPIVWg5nn9CpgLyKI=; b=PTjFiY8183yy3nlSE99qlgC28FTSwZrpoXVwmSCxCHXflgVgn7vSw8sFt7RMS0SNrg qIx//wxfDD6WOE8Z7O3Yg0sHrwLdcCF3gpqGPaq4H+czQqYHTqdOUUA5OZI53Wd/9Y+u YuLMq9TrShiFPrAOZJGYXqpWkerbjBA+QNav59Aa+E0rDbfDJJQVQ3gCsndQkOJmN5Ls Hc/2Tmcfa9VoX+woNVAz3NJFeQGJSWC+OrrY1qnZE3T9WY8b4fFbSbA81pcvQ3i0eHct 3y+ioOI+D+RGDYjYU1zgIftN7tYqMqNMdTSvmKp0JeugQAhLmgKZJPokyMJJzu7sBz7+ Vd/A== X-Gm-Message-State: AA+aEWZBvoY8yr2g2o2Ju72v2zO9WN6fXI7a93rw1kkhZeW9vqWQHxbI ccGp4STT+QFiNq5z3/0yYs/Q9w== X-Google-Smtp-Source: AFSGD/WWVh5yoCU3KyQUXD36gGUJZ09GN2NPvsKU0c6SJWSKUJRoV2L3noF9Rfh3VwruvTnRWy0QEQ== X-Received: by 2002:a17:902:584:: with SMTP id f4mr27947535plf.28.1543461393071; Wed, 28 Nov 2018 19:16:33 -0800 (PST) Received: from hsinyi-z840.tpe.corp.google.com ([2401:fa00:1:10:b852:bd51:9305:4261]) by smtp.gmail.com with ESMTPSA id z62sm555644pfi.4.2018.11.28.19.16.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 28 Nov 2018 19:16:32 -0800 (PST) From: "Hsin-Yi, Wang" To: linux-arm-kernel@lists.infradead.org Cc: Chunfeng Yun , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v4] usb/mtu3: power down device ip at setup Date: Thu, 29 Nov 2018 11:16:27 +0800 Message-Id: <20181129031627.45006-1-hsinyi@chromium.org> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20181128095358.42498-1-hsinyi@chromium.org> References: <20181128095358.42498-1-hsinyi@chromium.org> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Originally, when dr_mode is USB_DR_MODE_HOST, it didn't power down device ip, so host ip sleep will fail at ssusb_host_disable. Power down device ip at ssusb_host_setup. Signed-off-by: Hsin-Yi, Wang Acked-by: Chunfeng Yun --- ChangeLog: V3->V4: *update comment --- drivers/usb/mtu3/mtu3_plat.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/usb/mtu3/mtu3_plat.c b/drivers/usb/mtu3/mtu3_plat.c index 46551f6d16fd..e086630e41a9 100644 --- a/drivers/usb/mtu3/mtu3_plat.c +++ b/drivers/usb/mtu3/mtu3_plat.c @@ -200,6 +200,14 @@ static void ssusb_ip_sw_reset(struct ssusb_mtk *ssusb) mtu3_setbits(ssusb->ippc_base, U3D_SSUSB_IP_PW_CTRL0, SSUSB_IP_SW_RST); udelay(1); mtu3_clrbits(ssusb->ippc_base, U3D_SSUSB_IP_PW_CTRL0, SSUSB_IP_SW_RST); + + /* + * device ip may be powered on in firmware/BROM stage before entering + * kernel stage; + * power down device ip, otherwise ip-sleep will fail when working as + * host only mode + */ + mtu3_setbits(ssusb->ippc_base, U3D_SSUSB_IP_PW_CTRL2, SSUSB_IP_DEV_PDN); } /* ignore the error if the clock does not exist */