| Message ID | 20190808092509.GA20173@kroah.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | b6fd948832496f01750d6c87dfdcef713043da4c |
| Headers | show |
| Series | MAINTAINERS: mark wusbcore and UWB as obsolete | expand |
On Thu, Aug 08, 2019 at 11:25:09AM +0200, Greg Kroah-Hartman wrote: > Joe rightly points out that we should be using the "Obsolete" status for > these two subsystems. Even with that change, I don't see get_maintainers.pl tell me I shouldn't be sending a patch in for this area: $ cat x.patch diff --git a/drivers/staging/uwb/Kconfig b/drivers/staging/uwb/Kconfig index 259e053e1e09..d9658c46686e 100644 --- a/drivers/staging/uwb/Kconfig +++ b/drivers/staging/uwb/Kconfig @@ -3,6 +3,8 @@ # UWB device configuration # + + menuconfig UWB tristate "Ultra Wideband devices" default n $ ./scripts/get_maintainer.pl x.patch Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:STAGING SUBSYSTEM,commit_signer:2/2=100%,authored:1/2=50%) Thomas Gleixner <tglx@linutronix.de> (commit_signer:1/2=50%,authored:1/2=50%) devel@driverdev.osuosl.org (open list:ULTRA-WIDEBAND (UWB) SUBSYSTEM:) linux-kernel@vger.kernel.org (open list) Am I missing something? thanks, greg k-h
On Thu, 2019-08-08 at 11:41 +0200, Greg Kroah-Hartman wrote: > On Thu, Aug 08, 2019 at 11:25:09AM +0200, Greg Kroah-Hartman wrote: > > Joe rightly points out that we should be using the "Obsolete" status for > > these two subsystems. > > Even with that change, I don't see get_maintainers.pl tell me I > shouldn't be sending a patch in for this area: Nor should you. It's checkpatch that should warn. > > > $ cat x.patch > diff --git a/drivers/staging/uwb/Kconfig b/drivers/staging/uwb/Kconfig > index 259e053e1e09..d9658c46686e 100644 > --- a/drivers/staging/uwb/Kconfig > +++ b/drivers/staging/uwb/Kconfig > @@ -3,6 +3,8 @@ > # UWB device configuration > # > > + > + > menuconfig UWB > tristate "Ultra Wideband devices" > default n > $ ./scripts/get_maintainer.pl x.patch > Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:STAGING SUBSYSTEM,commit_signer:2/2=100%,authored:1/2=50%) > Thomas Gleixner <tglx@linutronix.de> (commit_signer:1/2=50%,authored:1/2=50%) > devel@driverdev.osuosl.org (open list:ULTRA-WIDEBAND (UWB) SUBSYSTEM:) > linux-kernel@vger.kernel.org (open list) > > > Am I missing something?
On Thu, Aug 08, 2019 at 04:15:44AM -0700, Joe Perches wrote: > On Thu, 2019-08-08 at 11:41 +0200, Greg Kroah-Hartman wrote: > > On Thu, Aug 08, 2019 at 11:25:09AM +0200, Greg Kroah-Hartman wrote: > > > Joe rightly points out that we should be using the "Obsolete" status for > > > these two subsystems. > > > > Even with that change, I don't see get_maintainers.pl tell me I > > shouldn't be sending a patch in for this area: > > Nor should you. It's checkpatch that should warn. Ah, wrong tool. Yes, it does, let's see if anyone actually notices that when sending checkpatch changes for these files in the future :) thanks, greg k-h
On Thu, 2019-08-08 at 13:23 +0200, Greg Kroah-Hartman wrote: > On Thu, Aug 08, 2019 at 04:15:44AM -0700, Joe Perches wrote: > > On Thu, 2019-08-08 at 11:41 +0200, Greg Kroah-Hartman wrote: > > > On Thu, Aug 08, 2019 at 11:25:09AM +0200, Greg Kroah-Hartman wrote: > > > > Joe rightly points out that we should be using the "Obsolete" status for > > > > these two subsystems. > > > > > > Even with that change, I don't see get_maintainers.pl tell me I > > > shouldn't be sending a patch in for this area: > > > > Nor should you. It's checkpatch that should warn. > > Ah, wrong tool. Yes, it does, let's see if anyone actually notices that > when sending checkpatch changes for these files in the future :) Maybe mark the isdn block obsolete too. https://lore.kernel.org/lkml/2ecfbf8dda354fe47912446bf5c3fe30ca905aa0.camel@perches.com/
diff --git a/MAINTAINERS b/MAINTAINERS index f4463fb48249..6f2d988fe7b0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3801,8 +3801,8 @@ F: scripts/extract-cert.c CERTIFIED WIRELESS USB (WUSB) SUBSYSTEM: L: devel@driverdev.osuosl.org -S: Orphan -F: drivers/staging/wbusbcore/ +S: Obsolete +F: drivers/staging/wusbcore/ CFAG12864B LCD DRIVER M: Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com> @@ -16443,7 +16443,7 @@ F: include/linux/ulpi/ ULTRA-WIDEBAND (UWB) SUBSYSTEM: L: devel@driverdev.osuosl.org -S: Orphan +S: Obsolete F: drivers/staging/uwb/ UNICODE SUBSYSTEM:
Joe rightly points out that we should be using the "Obsolete" status for these two subsystems. Also I got the path name wrong for the wusbcore tree. Reported-by: Joe Perches <joe@perches.com> Fixes: 71ed79b0e4be ("USB: Move wusbcore and UWB to staging as it is obsolete") Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>