| Message ID | 20190809173314.4623-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | b98052e9b5c4878f0e13b11cd5b7a04242c2d848 |
| Headers | show |
| Series | USB: storage: isd200: remove redundant assignment to variable sendToTransport | expand |
On Fri, 9 Aug 2019, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The variable sendToTransport is being initialized with a value that is > never read and is being re-assigned a little later on. The assignment > is redundant and hence can be removed. > > Addresses-Coverity: ("Unused value") Of what use is that tag to general kernel developers? > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/usb/storage/isd200.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/storage/isd200.c b/drivers/usb/storage/isd200.c > index 2b474d60b4db..28e1128d53a4 100644 > --- a/drivers/usb/storage/isd200.c > +++ b/drivers/usb/storage/isd200.c > @@ -1511,7 +1511,7 @@ static int isd200_Initialization(struct us_data *us) > > static void isd200_ata_command(struct scsi_cmnd *srb, struct us_data *us) > { > - int sendToTransport = 1, orig_bufflen; > + int sendToTransport, orig_bufflen; > union ata_cdb ataCdb; > > /* Make sure driver was initialized */ Otherwise: Acked-by: Alan Stern <stern@rowland.harvard.edu> Alan Stern
On 09/08/2019 20:29, Alan Stern wrote: > On Fri, 9 Aug 2019, Colin King wrote: > >> From: Colin Ian King <colin.king@canonical.com> >> >> The variable sendToTransport is being initialized with a value that is >> never read and is being re-assigned a little later on. The assignment >> is redundant and hence can be removed. >> >> Addresses-Coverity: ("Unused value") > > Of what use is that tag to general kernel developers? This is being informally used so that we can track which bugs are getting found with specific static analysis tools. The public coverity bug reports also have a CID# number. I'm working on range of coverity builds (different build configs) that are not public because I can crank multiple builds per day to find issues. Colin > >> Signed-off-by: Colin Ian King <colin.king@canonical.com> >> --- >> drivers/usb/storage/isd200.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/usb/storage/isd200.c b/drivers/usb/storage/isd200.c >> index 2b474d60b4db..28e1128d53a4 100644 >> --- a/drivers/usb/storage/isd200.c >> +++ b/drivers/usb/storage/isd200.c >> @@ -1511,7 +1511,7 @@ static int isd200_Initialization(struct us_data *us) >> >> static void isd200_ata_command(struct scsi_cmnd *srb, struct us_data *us) >> { >> - int sendToTransport = 1, orig_bufflen; >> + int sendToTransport, orig_bufflen; >> union ata_cdb ataCdb; >> >> /* Make sure driver was initialized */ > > Otherwise: > > Acked-by: Alan Stern <stern@rowland.harvard.edu> > > Alan Stern >
diff --git a/drivers/usb/storage/isd200.c b/drivers/usb/storage/isd200.c index 2b474d60b4db..28e1128d53a4 100644 --- a/drivers/usb/storage/isd200.c +++ b/drivers/usb/storage/isd200.c @@ -1511,7 +1511,7 @@ static int isd200_Initialization(struct us_data *us) static void isd200_ata_command(struct scsi_cmnd *srb, struct us_data *us) { - int sendToTransport = 1, orig_bufflen; + int sendToTransport, orig_bufflen; union ata_cdb ataCdb; /* Make sure driver was initialized */