| Message ID | 20190819100211.26791-1-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 2a59aa7711e0013f6ff27ba77e7b56eb7674ca97 |
| Headers | show |
| Series | usb: usb251xb: drop some unused defines | expand |
On Mon, Aug 19, 2019 at 12:02:11PM +0200, Uwe Kleine-König wrote: > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > drivers/usb/misc/usb251xb.c | 5 ----- > 1 file changed, 5 deletions(-) I can't take a patch without any changelog text. And you forgot to cc: the usb maintainer, so there's no way this was going to get merged :) thanks, greg k-h
On Mon, Aug 19, 2019 at 12:41:04PM +0200, Greg KH wrote: > On Mon, Aug 19, 2019 at 12:02:11PM +0200, Uwe Kleine-König wrote: > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > --- > > drivers/usb/misc/usb251xb.c | 5 ----- > > 1 file changed, 5 deletions(-) > > I can't take a patch without any changelog text. So I am supposed to repeat the Subject's content in the body? I completely agree that an expressive changelog is important for changes that actually change something. But it seems silly to me to describe something trivial in more words than necessary. There is zero added value; only added noise. > And you forgot to cc: the usb maintainer, so there's no way this was > going to get merged :) I would have expected that it is fine to direct to the contacts listed in the "MICROCHIP USB251XB DRIVER" section of MAINTAINERS and then let the people there care for forwarding. (And other than that it seems I catched the attention of the usb maintainer :-) Best regards Uwe
diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c index 5f7734c729b1..e2d36da52663 100644 --- a/drivers/usb/misc/usb251xb.c +++ b/drivers/usb/misc/usb251xb.c @@ -25,10 +25,6 @@ #define USB251XB_ADDR_PRODUCT_ID_LSB 0x02 #define USB251XB_ADDR_PRODUCT_ID_MSB 0x03 -#define USB251XB_DEF_PRODUCT_ID_12 0x2512 /* USB2512B/12Bi */ -#define USB251XB_DEF_PRODUCT_ID_13 0x2513 /* USB2513B/13Bi */ -#define USB251XB_DEF_PRODUCT_ID_14 0x2514 /* USB2514B/14Bi */ -#define USB251XB_DEF_PRODUCT_ID_17 0x2517 /* USB2517/17i */ #define USB251XB_ADDR_DEVICE_ID_LSB 0x04 #define USB251XB_ADDR_DEVICE_ID_MSB 0x05 @@ -73,7 +69,6 @@ #define USB251XB_ADDR_PRODUCT_STRING_LEN 0x14 #define USB251XB_ADDR_PRODUCT_STRING 0x54 -#define USB251XB_DEF_PRODUCT_STRING "USB251xB/xBi/7i" #define USB251XB_ADDR_SERIAL_STRING_LEN 0x15 #define USB251XB_ADDR_SERIAL_STRING 0x92
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/usb/misc/usb251xb.c | 5 ----- 1 file changed, 5 deletions(-)