| Message ID | 20191003070931.17009-1-johan@kernel.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 177238c3d47d54b2ed8f0da7a4290db492f4a057 |
| Headers | show |
| Series | USB: microtek: fix info-leak at probe | expand |
Am Donnerstag, den 03.10.2019, 09:09 +0200 schrieb Johan Hovold: > Add missing bulk-in endpoint sanity check to prevent uninitialised stack > data from being reported to the system log and used as endpoint > addresses. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Cc: stable <stable@vger.kernel.org> > Reported-by: syzbot+5630ca7c3b2be5c9da5e@syzkaller.appspotmail.com > Signed-off-by: Johan Hovold <johan@kernel.org> Acked-by: Oliver Neukum <oneukum@suse.com>
diff --git a/drivers/usb/image/microtek.c b/drivers/usb/image/microtek.c index 0a57c2cc8e5a..7a6b122c833f 100644 --- a/drivers/usb/image/microtek.c +++ b/drivers/usb/image/microtek.c @@ -716,6 +716,10 @@ static int mts_usb_probe(struct usb_interface *intf, } + if (ep_in_current != &ep_in_set[2]) { + MTS_WARNING("couldn't find two input bulk endpoints. Bailing out.\n"); + return -ENODEV; + } if ( ep_out == -1 ) { MTS_WARNING( "couldn't find an output bulk endpoint. Bailing out.\n" );
Add missing bulk-in endpoint sanity check to prevent uninitialised stack data from being reported to the system log and used as endpoint addresses. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable <stable@vger.kernel.org> Reported-by: syzbot+5630ca7c3b2be5c9da5e@syzkaller.appspotmail.com Signed-off-by: Johan Hovold <johan@kernel.org> --- drivers/usb/image/microtek.c | 4 ++++ 1 file changed, 4 insertions(+)