diff mbox series

[v3,1/7] usb: musb: dma: Correct parameter passed to IRQ handler

Message ID 20191210171110.62141-1-paul@crapouillou.net (mailing list archive)
State New, archived
Headers show
Series [v3,1/7] usb: musb: dma: Correct parameter passed to IRQ handler | expand

Commit Message

Paul Cercueil Dec. 10, 2019, 5:11 p.m. UTC 
The IRQ handler was passed a pointer to a struct dma_controller, but the
argument was then casted to a pointer to a struct musb_dma_controller.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Tested-by: Artur Rojek <contact@artur-rojek.eu>
---

Notes:
    v2: Rebase on 5.4-rc4
    v3: Rebase on 5.5-rc1

 drivers/usb/musb/musbhsdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bin Liu Dec. 11, 2019, 6:51 p.m. UTC | #1 
On Tue, Dec 10, 2019 at 06:11:04PM +0100, Paul Cercueil wrote:
> The IRQ handler was passed a pointer to a struct dma_controller, but the
> argument was then casted to a pointer to a struct musb_dma_controller.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> Tested-by: Artur Rojek <contact@artur-rojek.eu>
> ---

I added the Fixes tag, and queued for next v5.5 -rc. Thanks.

-Bin.
diff mbox series

Patch

diff --git a/drivers/usb/musb/musbhsdma.c b/drivers/usb/musb/musbhsdma.c
index 5fc6825745f2..2d3751d885b4 100644
--- a/drivers/usb/musb/musbhsdma.c
+++ b/drivers/usb/musb/musbhsdma.c
@@ -425,7 +425,7 @@  struct dma_controller *musbhs_dma_controller_create(struct musb *musb,
 	controller->controller.channel_abort = dma_channel_abort;
 
 	if (request_irq(irq, dma_controller_irq, 0,
-			dev_name(musb->controller), &controller->controller)) {
+			dev_name(musb->controller), controller)) {
 		dev_err(dev, "request_irq %d failed!\n", irq);
 		musb_dma_controller_destroy(&controller->controller);