diff mbox series

[v3,09/16] usb: phy: tegra: Assert reset on ULPI close instead of deasserting it

Message ID 20191228203358.23490-10-digetx@gmail.com (mailing list archive)
State Superseded
Headers show
Series NVIDIA Tegra USB2 drivers clean up | expand

Commit Message

Dmitry Osipenko Dec. 28, 2019, 8:33 p.m. UTC 
Apparently ULPI was meant to be put into reset on PHY's shutdown (which is
active-low state of the GPIO), but there is a typo in the code.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/usb/phy/phy-tegra-usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c
index 0845fc0fb3f8..1ecd9f7900af 100644
--- a/drivers/usb/phy/phy-tegra-usb.c
+++ b/drivers/usb/phy/phy-tegra-usb.c
@@ -308,7 +308,7 @@  static void ulpi_close(struct tegra_usb_phy *phy)
 {
 	int err;
 
-	err = gpio_direction_output(phy->reset_gpio, 1);
+	err = gpio_direction_output(phy->reset_gpio, 0);
 	if (err) {
 		dev_err(phy->u_phy.dev,
 			"ULPI reset GPIO %d direction not asserted: %d\n",