| Message ID | 20200108131347.43217-3-heikki.krogerus@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ucsi driver fixes | expand |
Hi Greg, On Wed, Jan 08, 2020 at 04:13:47PM +0300, Heikki Krogerus wrote: > The notification mask was not updated properly before all > the notifications were enabled in ucsi_init(). > > Fixes: 71a1fa0df2a3 ("usb: typec: ucsi: Store the notification mask") That commit (71a1fa0df2a3) is still in your usb-next branch, so this patch should also go only to your usb-next. Sorry about the mix-up. > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/ucsi/ucsi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c > index 466bd8afceea..59c8ccdc68ac 100644 > --- a/drivers/usb/typec/ucsi/ucsi.c > +++ b/drivers/usb/typec/ucsi/ucsi.c > @@ -1007,6 +1007,7 @@ int ucsi_init(struct ucsi *ucsi) > } > > /* Enable all notifications */ > + ucsi->ntfy = UCSI_ENABLE_NTFY_ALL; > command = UCSI_SET_NOTIFICATION_ENABLE | ucsi->ntfy; > ret = ucsi_run_command(ucsi, command, NULL, 0); > if (ret < 0) > -- > 2.24.1 thanks,
On Wed, Jan 08, 2020 at 05:29:42PM +0200, Heikki Krogerus wrote: > Hi Greg, > > On Wed, Jan 08, 2020 at 04:13:47PM +0300, Heikki Krogerus wrote: > > The notification mask was not updated properly before all > > the notifications were enabled in ucsi_init(). > > > > Fixes: 71a1fa0df2a3 ("usb: typec: ucsi: Store the notification mask") > > That commit (71a1fa0df2a3) is still in your usb-next branch, so this > patch should also go only to your usb-next. > > Sorry about the mix-up. No problem, I'll split the two patches between my two branches, thanks for the heads-up. greg k-h
diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c index 466bd8afceea..59c8ccdc68ac 100644 --- a/drivers/usb/typec/ucsi/ucsi.c +++ b/drivers/usb/typec/ucsi/ucsi.c @@ -1007,6 +1007,7 @@ int ucsi_init(struct ucsi *ucsi) } /* Enable all notifications */ + ucsi->ntfy = UCSI_ENABLE_NTFY_ALL; command = UCSI_SET_NOTIFICATION_ENABLE | ucsi->ntfy; ret = ucsi_run_command(ucsi, command, NULL, 0); if (ret < 0)
The notification mask was not updated properly before all the notifications were enabled in ucsi_init(). Fixes: 71a1fa0df2a3 ("usb: typec: ucsi: Store the notification mask") Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> --- drivers/usb/typec/ucsi/ucsi.c | 1 + 1 file changed, 1 insertion(+)