From patchwork Fri Mar 27 05:38:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 11461665 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 633281668 for ; Fri, 27 Mar 2020 05:39:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4BC7B206DB for ; Fri, 27 Mar 2020 05:39:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726333AbgC0Fi7 (ORCPT ); Fri, 27 Mar 2020 01:38:59 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:34937 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725936AbgC0Fi7 (ORCPT ); Fri, 27 Mar 2020 01:38:59 -0400 Received: from dude.hi.pengutronix.de ([2001:67c:670:100:1d::7]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jHhhk-00085G-Qu; Fri, 27 Mar 2020 06:38:52 +0100 Received: from ore by dude.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1jHhhj-0001QA-LF; Fri, 27 Mar 2020 06:38:51 +0100 From: Oleksij Rempel To: Bin Liu Cc: Oleksij Rempel , Michael Grzeschik , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team , Greg Kroah-Hartman , linux-usb@vger.kernel.org, russell@personaltelco.net, fercerpav@gmail.com Subject: [PATCH v1] usb: musb: dsps: set MUSB_DA8XX quirk for AM335x Date: Fri, 27 Mar 2020 06:38:49 +0100 Message-Id: <20200327053849.5348-1-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.26.0.rc2 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-usb@vger.kernel.org Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Beagle Bone Black has different memory corruptions if kernel is configured with USB_TI_CPPI41_DMA=y. This issue is reproducible with ath9k-htc driver (ar9271 based wifi usb controller): root@AccessBox:~ iw dev wlan0 set monitor fcsfail otherbss root@AccessBox:~ ip l s dev wlan0 up kmemleak: Cannot insert 0xda577e40 into the object search tree (overlaps existing) CPU: 0 PID: 176 Comm: ip Not tainted 5.5.0 #7 Hardware name: Generic AM33XX (Flattened Device Tree) [] (unwind_backtrace) from [] (show_stack+0x18/0x1c) [] (show_stack) from [] (dump_stack+0x84/0x98) [] (dump_stack) from [] (create_object+0x2f8/0x324) [] (create_object) from [] (kmem_cache_alloc+0x1a8/0x39c) [] (kmem_cache_alloc) from [] (__alloc_skb+0x60/0x174) [] (__alloc_skb) from [] (ath9k_wmi_cmd+0x50/0x184 [ath9k_htc]) [] (ath9k_wmi_cmd [ath9k_htc]) from [] (ath9k_regwrite_multi+0x54/0x84 [ath9k_htc]) [] (ath9k_regwrite_multi [ath9k_htc]) from [] (ath9k_regwrite+0xf0/0xfc [ath9k_htc]) [] (ath9k_regwrite [ath9k_htc]) from [] (ar5008_hw_process_ini+0x280/0x6c0 [ath9k_hw]) [] (ar5008_hw_process_ini [ath9k_hw]) from [] (ath9k_hw_reset+0x270/0x1458 [ath9k_hw]) [] (ath9k_hw_reset [ath9k_hw]) from [] (ath9k_htc_start+0xb0/0x22c [ath9k_htc]) [] (ath9k_htc_start [ath9k_htc]) from [] (drv_start+0x4c/0x1e8 [mac80211]) [] (drv_start [mac80211]) from [] (ieee80211_do_open+0x480/0x954 [mac80211]) [] (ieee80211_do_open [mac80211]) from [] (__dev_open+0xdc/0x160) [] (__dev_open) from [] (__dev_change_flags+0x1a4/0x204) [] (__dev_change_flags) from [] (dev_change_flags+0x20/0x50) [] (dev_change_flags) from [] (do_setlink+0x2ac/0x978) After applying this patch, the system is running in monitor mode without noticeable issues. Suggested-by: Michael Grzeschik Signed-off-by: Oleksij Rempel --- drivers/usb/musb/musb_dsps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c index 88923175f71e..c01f9e9e69f5 100644 --- a/drivers/usb/musb/musb_dsps.c +++ b/drivers/usb/musb/musb_dsps.c @@ -690,7 +690,7 @@ static void dsps_dma_controller_resume(struct dsps_glue *glue) {} #endif /* CONFIG_USB_TI_CPPI41_DMA */ static struct musb_platform_ops dsps_ops = { - .quirks = MUSB_DMA_CPPI41 | MUSB_INDEXED_EP, + .quirks = MUSB_DMA_CPPI41 | MUSB_INDEXED_EP | MUSB_DA8XX, .init = dsps_musb_init, .exit = dsps_musb_exit,