From patchwork Wed Nov 4 16:47:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 11881565 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 711EC14B4 for ; Wed, 4 Nov 2020 16:48:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 52150206DB for ; Wed, 4 Nov 2020 16:48:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604508537; bh=ADDN6DsGE/gZ/+s4uwypL7nna9X+zkn9j5t1bsvpSYk=; h=From:To:Cc:Subject:Date:List-ID:From; b=Y8XJjKjcb/yMMCG7vLm3nnBeDSDG3NUkzpxOMe2mmOHZYWvyJJsRD2OHoCRJZHU2O m4eSuMzfs1Fk9nk3S4sWrkofywc6o1oT+HiIdqbqENXvT98FH8fgDXZDTkFz1zxFIA iA6fa93bMclis68LzuDUC1m96yIz1tzsWVgtj6os= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731351AbgKDQsx (ORCPT ); Wed, 4 Nov 2020 11:48:53 -0500 Received: from mail-lf1-f68.google.com ([209.85.167.68]:40711 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728986AbgKDQsx (ORCPT ); Wed, 4 Nov 2020 11:48:53 -0500 Received: by mail-lf1-f68.google.com with SMTP id e27so5157750lfn.7; Wed, 04 Nov 2020 08:48:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=re+vkNaV2IqjWLvWTPODjB+TaAeDQ2wT/vcW13BpaME=; b=hZgf1e/JBLQ+7uV5maGFzSLIT+XSMPvNazHtC+O1xqTEk/IQmvbsz3rKJP2JaxYffU EVrvigq7sHxZCvEBnJayW7UGHlr0IVoBGo3tLkMCZntgOZtPrDOZzY4OeD4RVQU2H12b kHwpiXiBvzDgvl6eQIIUzHLLQASteX29wXy1iYsHuFPYIhmytFLizfnwllTUS27AyNX2 b+QiQhXRV8poTZMKhmqElW/JCbN6hKtNZvBPzALUfNQAeSd25sKbOqAoJK+8/gp+KMcB UbbrwVSdsip2f438bDuKGB2VRPfrtrpqzwTcAIbl4NKPb1B1tqM7u/Pri15EGT6tuLko 9IzA== X-Gm-Message-State: AOAM533I9AJaTecfZjJWXkSZm1fCvA+6nXQsdWiR+7G6supFZo9xWGst ocSe7SknoTqCKpNkZTmb/g05MC7yMOnYcA== X-Google-Smtp-Source: ABdhPJyFhRIgQ3n36N/ci6UZOj02hZ7KVRNUZCAsNwUfwnbWw2KB5ijNn73AuDv5Kvhn7VnHmrRucw== X-Received: by 2002:a19:c80a:: with SMTP id y10mr10860686lff.329.1604508530318; Wed, 04 Nov 2020 08:48:50 -0800 (PST) Received: from xi.terra (c-beaee455.07-184-6d6c6d4.bbcust.telenor.se. [85.228.174.190]) by smtp.gmail.com with ESMTPSA id x4sm563021ljj.62.2020.11.04.08.48.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 08:48:49 -0800 (PST) Received: from johan by xi.terra with local (Exim 4.93.0.4) (envelope-from ) id 1kaLxu-0006sC-BR; Wed, 04 Nov 2020 17:48:54 +0100 From: Johan Hovold To: linux-usb@vger.kernel.org Cc: Davidlohr Bueso , linux-kernel@vger.kernel.org, Johan Hovold , stable Subject: [PATCH] USB: serial: mos7720: fix parallel-port state restore Date: Wed, 4 Nov 2020 17:47:27 +0100 Message-Id: <20201104164727.26351-1-johan@kernel.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The parallel-port restore operations is called when a driver claims the port and is supposed to restore the provided state (e.g. saved when releasing the port). Fixes: b69578df7e98 ("USB: usbserial: mos7720: add support for parallel port on moschip 7715") Cc: stable # 2.6.35 Signed-off-by: Johan Hovold Reviewed-by: Greg Kroah-Hartman --- drivers/usb/serial/mos7720.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c index 5eed1078fac8..5a5d2a95070e 100644 --- a/drivers/usb/serial/mos7720.c +++ b/drivers/usb/serial/mos7720.c @@ -639,6 +639,8 @@ static void parport_mos7715_restore_state(struct parport *pp, spin_unlock(&release_lock); return; } + mos_parport->shadowDCR = s->u.pc.ctr; + mos_parport->shadowECR = s->u.pc.ecr; write_parport_reg_nonblock(mos_parport, MOS7720_DCR, mos_parport->shadowDCR); write_parport_reg_nonblock(mos_parport, MOS7720_ECR,