| Message ID | 20210116090656.11752-3-chunfeng.yun@mediatek.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [next,01/15] dt-bindings: usb: fix yamllint check warning | expand |
Hi, Chunfeng: Chunfeng Yun <chunfeng.yun@mediatek.com> 於 2021年1月16日 週六 下午5:07寫道： > > The compatilbe "mediatek,mt7623-mipi-tx" is not supported in driver, > and in fact uses "mediatek,mt2701-mipi-tx" instead on MT7623, so changes > the compatible items to make dependence clear. > > And add an optional "clock-names" property, it's not used to get the clock, > but some DTS files provide it. Separate the clock part to another patch. Regards, Chun-Kuang. > > Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > --- > .../bindings/phy/mediatek,dsi-phy.yaml | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml > index 71d4acea1f66..af6e554c5b69 100644 > --- a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml > @@ -19,11 +19,14 @@ properties: > pattern: "^dsi-phy@[0-9a-f]+$" > > compatible: > - enum: > - - mediatek,mt2701-mipi-tx > - - mediatek,mt7623-mipi-tx > - - mediatek,mt8173-mipi-tx > - - mediatek,mt8183-mipi-tx > + oneOf: > + - items: > + - enum: > + - mediatek,mt7623-mipi-tx > + - const: mediatek,mt2701-mipi-tx > + - const: mediatek,mt2701-mipi-tx > + - const: mediatek,mt8173-mipi-tx > + - const: mediatek,mt8183-mipi-tx > > reg: > maxItems: 1 > @@ -32,6 +35,10 @@ properties: > items: > - description: PLL reference clock > > + clock-names: > + items: > + - const: ref > + > clock-output-names: > maxItems: 1 > > -- > 2.18.0
On Mon, 2021-01-18 at 22:56 +0800, Chun-Kuang Hu wrote: > Hi, Chunfeng: > > Chunfeng Yun <chunfeng.yun@mediatek.com> 於 2021年1月16日 週六 下午5:07寫道： > > > > The compatilbe "mediatek,mt7623-mipi-tx" is not supported in driver, > > and in fact uses "mediatek,mt2701-mipi-tx" instead on MT7623, so changes > > the compatible items to make dependence clear. > > > > And add an optional "clock-names" property, it's not used to get the clock, > > but some DTS files provide it. > > Separate the clock part to another patch. Ok, will do it. > > Regards, > Chun-Kuang. > > > > > Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org> > > Cc: Philipp Zabel <p.zabel@pengutronix.de> > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > > --- > > .../bindings/phy/mediatek,dsi-phy.yaml | 17 ++++++++++++----- > > 1 file changed, 12 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml > > index 71d4acea1f66..af6e554c5b69 100644 > > --- a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml > > @@ -19,11 +19,14 @@ properties: > > pattern: "^dsi-phy@[0-9a-f]+$" > > > > compatible: > > - enum: > > - - mediatek,mt2701-mipi-tx > > - - mediatek,mt7623-mipi-tx > > - - mediatek,mt8173-mipi-tx > > - - mediatek,mt8183-mipi-tx > > + oneOf: > > + - items: > > + - enum: > > + - mediatek,mt7623-mipi-tx > > + - const: mediatek,mt2701-mipi-tx > > + - const: mediatek,mt2701-mipi-tx > > + - const: mediatek,mt8173-mipi-tx > > + - const: mediatek,mt8183-mipi-tx > > > > reg: > > maxItems: 1 > > @@ -32,6 +35,10 @@ properties: > > items: > > - description: PLL reference clock > > > > + clock-names: > > + items: > > + - const: ref > > + > > clock-output-names: > > maxItems: 1 > > > > -- > > 2.18.0
diff --git a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml index 71d4acea1f66..af6e554c5b69 100644 --- a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml +++ b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml @@ -19,11 +19,14 @@ properties: pattern: "^dsi-phy@[0-9a-f]+$" compatible: - enum: - - mediatek,mt2701-mipi-tx - - mediatek,mt7623-mipi-tx - - mediatek,mt8173-mipi-tx - - mediatek,mt8183-mipi-tx + oneOf: + - items: + - enum: + - mediatek,mt7623-mipi-tx + - const: mediatek,mt2701-mipi-tx + - const: mediatek,mt2701-mipi-tx + - const: mediatek,mt8173-mipi-tx + - const: mediatek,mt8183-mipi-tx reg: maxItems: 1 @@ -32,6 +35,10 @@ properties: items: - description: PLL reference clock + clock-names: + items: + - const: ref + clock-output-names: maxItems: 1
The compatilbe "mediatek,mt7623-mipi-tx" is not supported in driver, and in fact uses "mediatek,mt2701-mipi-tx" instead on MT7623, so changes the compatible items to make dependence clear. And add an optional "clock-names" property, it's not used to get the clock, but some DTS files provide it. Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org> Cc: Philipp Zabel <p.zabel@pengutronix.de> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- .../bindings/phy/mediatek,dsi-phy.yaml | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-)