| Message ID | 20210118111426.5147-3-johan@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2dc0e7c37549038444a5202e028ff5625c764012 |
| Headers | show |
| Series | USB: serial: cp210x: add software flow-control support | expand |
diff --git a/drivers/usb/serial/upd78f0730.c b/drivers/usb/serial/upd78f0730.c index 0a2268c479af..1ca9c1881621 100644 --- a/drivers/usb/serial/upd78f0730.c +++ b/drivers/usb/serial/upd78f0730.c @@ -145,14 +145,11 @@ static int upd78f0730_send_ctl(struct usb_serial_port *port, kfree(buf); - if (res != size) { + if (res < 0) { struct device *dev = &port->dev; dev_err(dev, "failed to send control request %02x: %d\n", *(u8 *)data, res); - /* The maximum expected length of a transfer is 6 bytes */ - if (res >= 0) - res = -EIO; return res; }
There's no need to check for short control transfers when sending data so remove the redundant sanity check. Signed-off-by: Johan Hovold <johan@kernel.org> --- drivers/usb/serial/upd78f0730.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)