From patchwork Thu Mar 18 15:51:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12148441 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2723C433E6 for ; Thu, 18 Mar 2021 15:52:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6CC1864F3B for ; Thu, 18 Mar 2021 15:52:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229508AbhCRPwU (ORCPT ); Thu, 18 Mar 2021 11:52:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:54640 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230477AbhCRPwA (ORCPT ); Thu, 18 Mar 2021 11:52:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2240B64EF6; Thu, 18 Mar 2021 15:52:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616082720; bh=+yNLBBpLQUesjQU9zH7hMX1JnxqzSjRK9z0Q3x+/JT8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hVkNpbIwu3KUht+BSIMxlDTC66nH0LJJuUUmJFIL7HUp2E/3BIAVCIiIdl+KZWL32 75kEEJs0ed7sfGdKrmvkXXNuW5ZmZrJqBBvXFv1xbL76b2xCYDl4Q4ex2z6UK6ju8l s1M0UCPiit+PEpct2Hep2Y8PnnZ8LMju98XYk36b+49QEjgtIOcIKvYdu5NzMbbwSN +k+CpG6F/C6GfKTCATfZU9790yVkJBNpGRDtlcdaZD4cYosu7pwr341/7x7+WcTAuT K6lhxUBDiWGyN7zqfk94vaKC8gsoKUM+HYpVDZoQw4ulkDDEHdphfPyKy04BZvtSDm djxfSDunEu1Xg== Received: from johan by xi.lan with local (Exim 4.93.0.4) (envelope-from ) id 1lMuwc-0005nU-5r; Thu, 18 Mar 2021 16:52:18 +0100 From: Johan Hovold To: Oliver Neukum , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 3/7] USB: cdc-acm: drop redundant driver-data assignment Date: Thu, 18 Mar 2021 16:51:58 +0100 Message-Id: <20210318155202.22230-4-johan@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210318155202.22230-1-johan@kernel.org> References: <20210318155202.22230-1-johan@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The interface driver data has already been set by usb_driver_claim_interface() so drop the redundant subsequent assignment. Signed-off-by: Johan Hovold Acked-by: Oliver Neukum --- drivers/usb/class/cdc-acm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index dfc2480add91..36dd1e05e455 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -1487,7 +1487,6 @@ static int acm_probe(struct usb_interface *intf, acm_set_line(acm, &acm->line); usb_driver_claim_interface(&acm_driver, data_interface, acm); - usb_set_intfdata(data_interface, acm); tty_dev = tty_port_register_device(&acm->port, acm_tty_driver, minor, &control_interface->dev);