| Message ID | 20210529120408.23456-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 90059e9395cae00d79ecb1f7e1e702756416bc6a |
| Headers | show |
| Series | [-next] USB: gadget: f_fs: Remove unneed cast in ffs_prepare_buffer() | expand |
On Sat, May 29, 2021 at 08:04:08PM +0800, YueHaibing wrote: > A coccicheck run provided information like the following. > > ./drivers/usb/gadget/function/f_fs.c:3832:9-16: > WARNING: ERR_CAST can be used with data > > ffs_prepare_buffer() should return an ERR_PTR() encoded error > code on failure. It does return such a pointer today, so this statement does not make much sense :( And is this a v2 patch? What changed from the previous version? thanks, greg k-h
On 2021/5/29 20:11, Greg KH wrote: > On Sat, May 29, 2021 at 08:04:08PM +0800, YueHaibing wrote: >> A coccicheck run provided information like the following. >> >> ./drivers/usb/gadget/function/f_fs.c:3832:9-16: >> WARNING: ERR_CAST can be used with data >> >> ffs_prepare_buffer() should return an ERR_PTR() encoded error >> code on failure. > > It does return such a pointer today, so this statement does not make > much sense :( Yes, it does. This is just to remove explicit casts. > > And is this a v2 patch? What changed from the previous version? Sorry, I forget to add version info. > > thanks, > > greg k-h > . >
diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c index bf109191659a..cb419bbd089c 100644 --- a/drivers/usb/gadget/function/f_fs.c +++ b/drivers/usb/gadget/function/f_fs.c @@ -3829,7 +3829,7 @@ static char *ffs_prepare_buffer(const char __user *buf, size_t len) data = memdup_user(buf, len); if (IS_ERR(data)) - return ERR_PTR(PTR_ERR(data)); + return data; pr_vdebug("Buffer from user space:\n"); ffs_dump_mem("", data, len);
A coccicheck run provided information like the following. ./drivers/usb/gadget/function/f_fs.c:3832:9-16: WARNING: ERR_CAST can be used with data ffs_prepare_buffer() should return an ERR_PTR() encoded error code on failure. Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/usb/gadget/function/f_fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)