| Message ID | 20210606200911.32076-3-andy.shevchenko@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v1,1/3] usb: typec: intel_pmc_mux: Put fwnode in error case during ->probe() | expand |
On Sun, Jun 06, 2021 at 11:09:11PM +0300, Andy Shevchenko wrote: > For ACPI devices we have a symmetric API to put them, so use it in the driver. > > Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/mux/intel_pmc_mux.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/typec/mux/intel_pmc_mux.c b/drivers/usb/typec/mux/intel_pmc_mux.c > index de40276cc18b..2d0a863956c7 100644 > --- a/drivers/usb/typec/mux/intel_pmc_mux.c > +++ b/drivers/usb/typec/mux/intel_pmc_mux.c > @@ -582,12 +582,12 @@ static int pmc_usb_probe_iom(struct pmc_usb *pmc) > acpi_dev_free_resource_list(&resource_list); > > if (!pmc->iom_base) { > - put_device(&adev->dev); > + acpi_dev_put(adev); > return -ENOMEM; > } > > if (IS_ERR(pmc->iom_base)) { > - put_device(&adev->dev); > + acpi_dev_put(adev); > return PTR_ERR(pmc->iom_base); > } > > @@ -657,7 +657,7 @@ static int pmc_usb_probe(struct platform_device *pdev) > usb_role_switch_unregister(pmc->port[i].usb_sw); > } > > - put_device(&pmc->iom_adev->dev); > + acpi_dev_put(pmc->iom_adev); > > return ret; > } > @@ -673,7 +673,7 @@ static int pmc_usb_remove(struct platform_device *pdev) > usb_role_switch_unregister(pmc->port[i].usb_sw); > } > > - put_device(&pmc->iom_adev->dev); > + acpi_dev_put(pmc->iom_adev); > > return 0; > } > -- > 2.31.1
diff --git a/drivers/usb/typec/mux/intel_pmc_mux.c b/drivers/usb/typec/mux/intel_pmc_mux.c index de40276cc18b..2d0a863956c7 100644 --- a/drivers/usb/typec/mux/intel_pmc_mux.c +++ b/drivers/usb/typec/mux/intel_pmc_mux.c @@ -582,12 +582,12 @@ static int pmc_usb_probe_iom(struct pmc_usb *pmc) acpi_dev_free_resource_list(&resource_list); if (!pmc->iom_base) { - put_device(&adev->dev); + acpi_dev_put(adev); return -ENOMEM; } if (IS_ERR(pmc->iom_base)) { - put_device(&adev->dev); + acpi_dev_put(adev); return PTR_ERR(pmc->iom_base); } @@ -657,7 +657,7 @@ static int pmc_usb_probe(struct platform_device *pdev) usb_role_switch_unregister(pmc->port[i].usb_sw); } - put_device(&pmc->iom_adev->dev); + acpi_dev_put(pmc->iom_adev); return ret; } @@ -673,7 +673,7 @@ static int pmc_usb_remove(struct platform_device *pdev) usb_role_switch_unregister(pmc->port[i].usb_sw); } - put_device(&pmc->iom_adev->dev); + acpi_dev_put(pmc->iom_adev); return 0; }
For ACPI devices we have a symmetric API to put them, so use it in the driver. Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com> --- drivers/usb/typec/mux/intel_pmc_mux.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)