diff mbox series

[v4,1/2] dt-bindings: connector: Add pd-supported property

Message ID 20210730061832.1927936-2-kyletso@google.com (mailing list archive)
State Superseded
Headers show
Series TCPM non-PD mode | expand

Commit Message

Kyle Tso July 30, 2021, 6:18 a.m. UTC
Set "pd-unsupported" property if the Type-C connector has no power
delivery support.

Signed-off-by: Kyle Tso <kyletso@google.com>
---
 .../devicetree/bindings/connector/usb-connector.yaml          | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Guenter Roeck July 30, 2021, 6:29 a.m. UTC | #1
On 7/29/21 11:18 PM, Kyle Tso wrote:
> Set "pd-unsupported" property if the Type-C connector has no power
> delivery support.
> 

subject is still wrong (it says pd-supported).


> Signed-off-by: Kyle Tso <kyletso@google.com>
> ---
>   .../devicetree/bindings/connector/usb-connector.yaml          | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> index 92b49bc37939..21ec470117a6 100644
> --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
> +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> @@ -111,6 +111,10 @@ properties:
>         - 1.5A
>         - 3.0A
>   
> +  pd-unsupported:
> +    description: Set this property if the Type-C connector has no power delivery support.
> +    type: boolean
> +
>     # The following are optional properties for "usb-c-connector" with power
>     # delivery support.
>     source-pdos:
>
Rob Herring (Arm) Aug. 3, 2021, 7:33 p.m. UTC | #2
On Thu, Jul 29, 2021 at 11:29:06PM -0700, Guenter Roeck wrote:
> On 7/29/21 11:18 PM, Kyle Tso wrote:
> > Set "pd-unsupported" property if the Type-C connector has no power
> > delivery support.
> > 
> 
> subject is still wrong (it says pd-supported).

And the commit msg too.

> 
> 
> > Signed-off-by: Kyle Tso <kyletso@google.com>
> > ---
> >   .../devicetree/bindings/connector/usb-connector.yaml          | 4 ++++
> >   1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> > index 92b49bc37939..21ec470117a6 100644
> > --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
> > +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> > @@ -111,6 +111,10 @@ properties:
> >         - 1.5A
> >         - 3.0A
> > +  pd-unsupported:
> > +    description: Set this property if the Type-C connector has no power delivery support.
> > +    type: boolean
> > +
> >     # The following are optional properties for "usb-c-connector" with power
> >     # delivery support.
> >     source-pdos:
> > 
> 
>
Rob Herring (Arm) Aug. 3, 2021, 7:35 p.m. UTC | #3
On Tue, Aug 3, 2021 at 1:33 PM Rob Herring <robh@kernel.org> wrote:
>
> On Thu, Jul 29, 2021 at 11:29:06PM -0700, Guenter Roeck wrote:
> > On 7/29/21 11:18 PM, Kyle Tso wrote:
> > > Set "pd-unsupported" property if the Type-C connector has no power
> > > delivery support.
> > >
> >
> > subject is still wrong (it says pd-supported).
>
> And the commit msg too.

Err, sorry, it's the cover letter that's wrong.

Rob
Rob Herring (Arm) Aug. 3, 2021, 7:37 p.m. UTC | #4
On Fri, Jul 30, 2021 at 02:18:31PM +0800, Kyle Tso wrote:
> Set "pd-unsupported" property if the Type-C connector has no power
> delivery support.
> 
> Signed-off-by: Kyle Tso <kyletso@google.com>
> ---
>  .../devicetree/bindings/connector/usb-connector.yaml          | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> index 92b49bc37939..21ec470117a6 100644
> --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
> +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> @@ -111,6 +111,10 @@ properties:
>        - 1.5A
>        - 3.0A
>  
> +  pd-unsupported:

'disable-pd' or 'pd-disable' would be a bit more consistent with other 
flags like to enable/disable things.

> +    description: Set this property if the Type-C connector has no power delivery support.
> +    type: boolean
> +
>    # The following are optional properties for "usb-c-connector" with power
>    # delivery support.
>    source-pdos:
> -- 
> 2.32.0.554.ge1b32706d8-goog
> 
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
index 92b49bc37939..21ec470117a6 100644
--- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
+++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
@@ -111,6 +111,10 @@  properties:
       - 1.5A
       - 3.0A
 
+  pd-unsupported:
+    description: Set this property if the Type-C connector has no power delivery support.
+    type: boolean
+
   # The following are optional properties for "usb-c-connector" with power
   # delivery support.
   source-pdos: