| Message ID | 20210918120934.28252-10-sven@svenpeter.dev (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | usb: typec: tipd: Add Apple M1 support | expand |
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> On Sat , Sep 18, 2021 at 02:09:34PM +0200, Sven Peter wrote: > The Apple i2c bus uses I2C_FUNC_I2C and I've tested this quite > extensivly in the past days. Remove the FIXME about that testing :-) > > Signed-off-by: Sven Peter <sven@svenpeter.dev> > --- > drivers/usb/typec/tipd/core.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c > index 26807c050662..3b6878e22ce9 100644 > --- a/drivers/usb/typec/tipd/core.c > +++ b/drivers/usb/typec/tipd/core.c > @@ -673,9 +673,6 @@ static int tps6598x_probe(struct i2c_client *client) > /* > * Checking can the adapter handle SMBus protocol. If it can not, the > * driver needs to take care of block reads separately. > - * > - * FIXME: Testing with I2C_FUNC_I2C. regmap-i2c uses I2C protocol > - * unconditionally if the adapter has I2C_FUNC_I2C set. > */ > if (i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) > tps->i2c_protocol = true; > -- > 2.25.1 >
On Sat, Sep 18, 2021 at 02:09:34PM +0200, Sven Peter wrote: > The Apple i2c bus uses I2C_FUNC_I2C and I've tested this quite > extensivly in the past days. Remove the FIXME about that testing :-) > > Signed-off-by: Sven Peter <sven@svenpeter.dev> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/tipd/core.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c > index 26807c050662..3b6878e22ce9 100644 > --- a/drivers/usb/typec/tipd/core.c > +++ b/drivers/usb/typec/tipd/core.c > @@ -673,9 +673,6 @@ static int tps6598x_probe(struct i2c_client *client) > /* > * Checking can the adapter handle SMBus protocol. If it can not, the > * driver needs to take care of block reads separately. > - * > - * FIXME: Testing with I2C_FUNC_I2C. regmap-i2c uses I2C protocol > - * unconditionally if the adapter has I2C_FUNC_I2C set. > */ > if (i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) > tps->i2c_protocol = true; > -- > 2.25.1 thanks,
diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c index 26807c050662..3b6878e22ce9 100644 --- a/drivers/usb/typec/tipd/core.c +++ b/drivers/usb/typec/tipd/core.c @@ -673,9 +673,6 @@ static int tps6598x_probe(struct i2c_client *client) /* * Checking can the adapter handle SMBus protocol. If it can not, the * driver needs to take care of block reads separately. - * - * FIXME: Testing with I2C_FUNC_I2C. regmap-i2c uses I2C protocol - * unconditionally if the adapter has I2C_FUNC_I2C set. */ if (i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) tps->i2c_protocol = true;
The Apple i2c bus uses I2C_FUNC_I2C and I've tested this quite extensivly in the past days. Remove the FIXME about that testing :-) Signed-off-by: Sven Peter <sven@svenpeter.dev> --- drivers/usb/typec/tipd/core.c | 3 --- 1 file changed, 3 deletions(-)