| Message ID | 20211206174113.2295616-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b13e2bd3d258719fe1bc91ad3c9ccce1df708510 |
| Headers | show |
| Series | dt-bindings: usb: Add missing properties used in examples | expand |
On Mon, Dec 06, 2021 at 11:41:12AM -0600, Rob Herring wrote: > With 'unevaluatedProperties' support implemented, the following warnings > are generated in the usb examples: > > Documentation/devicetree/bindings/usb/intel,keembay-dwc3.example.dt.yaml: usb: usb@34000000: Unevaluated properties are not allowed ('reg' was unexpected) > Documentation/devicetree/bindings/usb/snps,dwc3.example.dt.yaml: usb@4a030000: Unevaluated properties are not allowed ('reg' was unexpected) > > Add the missing property definitions. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@intel.com> > Cc: Felipe Balbi <balbi@kernel.org> > Cc: linux-usb@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > .../devicetree/bindings/usb/intel,keembay-dwc3.yaml | 3 +++ > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 6 ++++++ > 2 files changed, 9 insertions(+) Do you want me to take these in my tree? If not, you can take them in yours: Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Which ever is easier for you. greg k-h
On Mon, Dec 06, 2021 at 11:41:12AM -0600, Rob Herring wrote: > With 'unevaluatedProperties' support implemented, the following warnings > are generated in the usb examples: > > Documentation/devicetree/bindings/usb/intel,keembay-dwc3.example.dt.yaml: usb: usb@34000000: Unevaluated properties are not allowed ('reg' was unexpected) > Documentation/devicetree/bindings/usb/snps,dwc3.example.dt.yaml: usb@4a030000: Unevaluated properties are not allowed ('reg' was unexpected) > > Add the missing property definitions. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@intel.com> > Cc: Felipe Balbi <balbi@kernel.org> > Cc: linux-usb@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > .../devicetree/bindings/usb/intel,keembay-dwc3.yaml | 3 +++ > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 6 ++++++ > 2 files changed, 9 insertions(+) Reviewed-by: Thierry Reding <treding@nvidia.com>
On Mon, Dec 06, 2021 at 07:25:09PM +0100, Greg Kroah-Hartman wrote: > On Mon, Dec 06, 2021 at 11:41:12AM -0600, Rob Herring wrote: > > With 'unevaluatedProperties' support implemented, the following warnings > > are generated in the usb examples: > > > > Documentation/devicetree/bindings/usb/intel,keembay-dwc3.example.dt.yaml: usb: usb@34000000: Unevaluated properties are not allowed ('reg' was unexpected) > > Documentation/devicetree/bindings/usb/snps,dwc3.example.dt.yaml: usb@4a030000: Unevaluated properties are not allowed ('reg' was unexpected) > > > > Add the missing property definitions. > > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Cc: Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@intel.com> > > Cc: Felipe Balbi <balbi@kernel.org> > > Cc: linux-usb@vger.kernel.org > > Signed-off-by: Rob Herring <robh@kernel.org> > > --- > > .../devicetree/bindings/usb/intel,keembay-dwc3.yaml | 3 +++ > > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 6 ++++++ > > 2 files changed, 9 insertions(+) > > Do you want me to take these in my tree? If not, you can take them in > yours: > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Which ever is easier for you. I'll take them. Rob
diff --git a/Documentation/devicetree/bindings/usb/intel,keembay-dwc3.yaml b/Documentation/devicetree/bindings/usb/intel,keembay-dwc3.yaml index 43b91ab62004..d3511f48cd55 100644 --- a/Documentation/devicetree/bindings/usb/intel,keembay-dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/intel,keembay-dwc3.yaml @@ -13,6 +13,9 @@ properties: compatible: const: intel,keembay-dwc3 + reg: + maxItems: 1 + clocks: maxItems: 4 diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml index 25ac2c93dc6c..d29ffcd27472 100644 --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml @@ -36,6 +36,9 @@ properties: - const: synopsys,dwc3 deprecated: true + reg: + maxItems: 1 + interrupts: description: It's either a single common DWC3 interrupt (dwc_usb3) or individual @@ -65,6 +68,9 @@ properties: - enum: [bus_early, ref, suspend] - true + iommus: + maxItems: 1 + usb-phy: minItems: 1 items:
With 'unevaluatedProperties' support implemented, the following warnings are generated in the usb examples: Documentation/devicetree/bindings/usb/intel,keembay-dwc3.example.dt.yaml: usb: usb@34000000: Unevaluated properties are not allowed ('reg' was unexpected) Documentation/devicetree/bindings/usb/snps,dwc3.example.dt.yaml: usb@4a030000: Unevaluated properties are not allowed ('reg' was unexpected) Add the missing property definitions. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@intel.com> Cc: Felipe Balbi <balbi@kernel.org> Cc: linux-usb@vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org> --- .../devicetree/bindings/usb/intel,keembay-dwc3.yaml | 3 +++ Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 6 ++++++ 2 files changed, 9 insertions(+)