| Message ID | 20220112054950.615341-1-waynec@nvidia.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v4,1/1] ucsi_ccg: Check DEV_INT bit only when starting CCG4 | expand |
On Wed, Jan 12, 2022 at 01:49:50PM +0800, Wayne Chang wrote: > From: Sing-Han Chen <singhanc@nvidia.com> > > after driver sending the UCSI_START cmd, CCGx would > clear Bit 0:Device Interrupt in the INTR_REG if CCGX > reset successfully. > > however, there might be a chance that other bits in > INTR_REG are not cleared due to internal data queued > in PPM and cause the driver thinks CCGx reset failed. > > the commit checks bit 0 in INTR_REG and ignore other > bits. ucsi driver would reset PPM later. > > Fixes: 247c554a14aa ("usb: typec: ucsi: add support for Cypress CCGx") > Signed-off-by: Sing-Han Chen <singhanc@nvidia.com> > Signed-off-by: Wayne Chang <waynec@nvidia.com> > --- > drivers/usb/typec/ucsi/ucsi_ccg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c > index bff96d64dddf..6db7c8ddd51c 100644 > --- a/drivers/usb/typec/ucsi/ucsi_ccg.c > +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c > @@ -325,7 +325,7 @@ static int ucsi_ccg_init(struct ucsi_ccg *uc) > if (status < 0) > return status; > > - if (!data) > + if (!(data & DEV_INT)) > return 0; > > status = ccg_write(uc, CCGX_RAB_INTR_REG, &data, sizeof(data)); > -- > 2.25.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
Hi, On Wed, Jan 12, 2022 at 01:49:50PM +0800, Wayne Chang wrote: > From: Sing-Han Chen <singhanc@nvidia.com> > > after driver sending the UCSI_START cmd, CCGx would > clear Bit 0:Device Interrupt in the INTR_REG if CCGX > reset successfully. > > however, there might be a chance that other bits in > INTR_REG are not cleared due to internal data queued > in PPM and cause the driver thinks CCGx reset failed. > > the commit checks bit 0 in INTR_REG and ignore other > bits. ucsi driver would reset PPM later. > > Fixes: 247c554a14aa ("usb: typec: ucsi: add support for Cypress CCGx") So... no need to take this to the stable kernel releases? > Signed-off-by: Sing-Han Chen <singhanc@nvidia.com> > Signed-off-by: Wayne Chang <waynec@nvidia.com> > --- What has changed since v3 (and v2) - there is no patch changelog here? In case this is new to you, you list those changes under that '---' line so they don't become part of the permanent changelog: https://docs.kernel.org/process/submitting-patches.html#the-canonical-patch-format > drivers/usb/typec/ucsi/ucsi_ccg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c > index bff96d64dddf..6db7c8ddd51c 100644 > --- a/drivers/usb/typec/ucsi/ucsi_ccg.c > +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c > @@ -325,7 +325,7 @@ static int ucsi_ccg_init(struct ucsi_ccg *uc) > if (status < 0) > return status; > > - if (!data) > + if (!(data & DEV_INT)) > return 0; > > status = ccg_write(uc, CCGX_RAB_INTR_REG, &data, sizeof(data)); thanks,
Hi Heikki Thanks for the review. On 1/12/22 3:50 PM, Heikki Krogerus wrote: > > > Hi, > > On Wed, Jan 12, 2022 at 01:49:50PM +0800, Wayne Chang wrote: >> From: Sing-Han Chen <singhanc@nvidia.com> >> >> after driver sending the UCSI_START cmd, CCGx would >> clear Bit 0:Device Interrupt in the INTR_REG if CCGX >> reset successfully. >> >> however, there might be a chance that other bits in >> INTR_REG are not cleared due to internal data queued >> in PPM and cause the driver thinks CCGx reset failed. >> >> the commit checks bit 0 in INTR_REG and ignore other >> bits. ucsi driver would reset PPM later. >> >> Fixes: 247c554a14aa ("usb: typec: ucsi: add support for Cypress CCGx") > > So... no need to take this to the stable kernel releases? > Should I put cc tag here? >> Signed-off-by: Sing-Han Chen <singhanc@nvidia.com> >> Signed-off-by: Wayne Chang <waynec@nvidia.com> >> --- > > What has changed since v3 (and v2) - there is no patch changelog here? > > In case this is new to you, you list those changes under that '---' > line so they don't become part of the permanent changelog: > > https://docs.kernel.org/process/submitting-patches.html#the-canonical-patch-format > The changes are resent for updating the commit messages. Added the Fixes tag which Greg asked for. Thanks for information. I went through the documents. Should I put the following messages in the patch after "---" or should I use resend in subject for the commit messages updated? v3 -> v4 commit messages updated v2 -> v3 commit messages updated v1 -> v2 commit messages updated >> drivers/usb/typec/ucsi/ucsi_ccg.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c >> index bff96d64dddf..6db7c8ddd51c 100644 >> --- a/drivers/usb/typec/ucsi/ucsi_ccg.c >> +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c >> @@ -325,7 +325,7 @@ static int ucsi_ccg_init(struct ucsi_ccg *uc) >> if (status < 0) >> return status; >> >> - if (!data) >> + if (!(data & DEV_INT)) >> return 0; >> >> status = ccg_write(uc, CCGX_RAB_INTR_REG, &data, sizeof(data)); > > thanks, > > -- > heikki > thanks, Wayne.
On Wed, Jan 12, 2022 at 08:41:50AM +0000, Wayne Chang wrote: > Hi Heikki > > Thanks for the review. > > On 1/12/22 3:50 PM, Heikki Krogerus wrote: > > > > > > Hi, > > > > On Wed, Jan 12, 2022 at 01:49:50PM +0800, Wayne Chang wrote: > >> From: Sing-Han Chen <singhanc@nvidia.com> > >> > >> after driver sending the UCSI_START cmd, CCGx would > >> clear Bit 0:Device Interrupt in the INTR_REG if CCGX > >> reset successfully. > >> > >> however, there might be a chance that other bits in > >> INTR_REG are not cleared due to internal data queued > >> in PPM and cause the driver thinks CCGx reset failed. > >> > >> the commit checks bit 0 in INTR_REG and ignore other > >> bits. ucsi driver would reset PPM later. > >> > >> Fixes: 247c554a14aa ("usb: typec: ucsi: add support for Cypress CCGx") > > > > So... no need to take this to the stable kernel releases? > > > Should I put cc tag here? Yes, Cc: stable@kernel.org, unless you have some good reason not to. I'm guessing you don't. This stuff is also explained here: https://docs.kernel.org/process/submitting-patches.html#select-the-recipients-for-your-patch > >> Signed-off-by: Sing-Han Chen <singhanc@nvidia.com> > >> Signed-off-by: Wayne Chang <waynec@nvidia.com> > >> --- > > > > What has changed since v3 (and v2) - there is no patch changelog here? > > > > In case this is new to you, you list those changes under that '---' > > line so they don't become part of the permanent changelog: > > > > https://docs.kernel.org/process/submitting-patches.html#the-canonical-patch-format > > > The changes are resent for updating the commit messages. > Added the Fixes tag which Greg asked for. > Thanks for information. I went through the documents. > Should I put the following messages in the patch after "---" or should I use resend in subject > for the commit messages updated? > v3 -> v4 commit messages updated I think you can say exactly what you did, like "Added the Fixes tag" or whatever you did. > v2 -> v3 commit messages updated Ditto. > v1 -> v2 commit messages updated Ditto. Since you are going to do one more version of this, could you also start the sentences with upper-case letters in the commit message? Normally I'm not very picky about the grammar stuff (I make plenty of mistakes myself), but this time it's driving me crazy for some reason. thanks,
On 1/12/22 5:09 PM, Heikki Krogerus wrote: > > > On Wed, Jan 12, 2022 at 08:41:50AM +0000, Wayne Chang wrote: >> Hi Heikki >> >> Thanks for the review. >> >> On 1/12/22 3:50 PM, Heikki Krogerus wrote: >>> >>> >>> Hi, >>> >>> On Wed, Jan 12, 2022 at 01:49:50PM +0800, Wayne Chang wrote: >>>> From: Sing-Han Chen <singhanc@nvidia.com> >>>> >>>> after driver sending the UCSI_START cmd, CCGx would >>>> clear Bit 0:Device Interrupt in the INTR_REG if CCGX >>>> reset successfully. >>>> >>>> however, there might be a chance that other bits in >>>> INTR_REG are not cleared due to internal data queued >>>> in PPM and cause the driver thinks CCGx reset failed. >>>> >>>> the commit checks bit 0 in INTR_REG and ignore other >>>> bits. ucsi driver would reset PPM later. >>>> >>>> Fixes: 247c554a14aa ("usb: typec: ucsi: add support for Cypress CCGx") >>> >>> So... no need to take this to the stable kernel releases? >>> >> Should I put cc tag here? > > Yes, Cc: stable@kernel.org, unless you have some good reason not to. > I'm guessing you don't. This stuff is also explained here: > > https://docs.kernel.org/process/submitting-patches.html#select-the-recipients-for-your-patch > Thanks for the information. I'll add the Cc tag in the next version. >>>> Signed-off-by: Sing-Han Chen <singhanc@nvidia.com> >>>> Signed-off-by: Wayne Chang <waynec@nvidia.com> >>>> --- >>> >>> What has changed since v3 (and v2) - there is no patch changelog here? >>> >>> In case this is new to you, you list those changes under that '---' >>> line so they don't become part of the permanent changelog: >>> >>> https://docs.kernel.org/process/submitting-patches.html#the-canonical-patch-format >>> >> The changes are resent for updating the commit messages. >> Added the Fixes tag which Greg asked for. >> Thanks for information. I went through the documents. >> Should I put the following messages in the patch after "---" or should I use resend in subject >> for the commit messages updated? >> v3 -> v4 commit messages updated > > I think you can say exactly what you did, like "Added the Fixes tag" > or whatever you did. > >> v2 -> v3 commit messages updated > > Ditto. > >> v1 -> v2 commit messages updated > > Ditto. > > Since you are going to do one more version of this, could you also > start the sentences with upper-case letters in the commit message? > Normally I'm not very picky about the grammar stuff (I make plenty of > mistakes myself), but this time it's driving me crazy for some reason. > Sure, I'll also minimize the words in a sentence and make it readable. Thanks for the advice. > thanks, > > -- > heikki > thanks, Wayne.
diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c index bff96d64dddf..6db7c8ddd51c 100644 --- a/drivers/usb/typec/ucsi/ucsi_ccg.c +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c @@ -325,7 +325,7 @@ static int ucsi_ccg_init(struct ucsi_ccg *uc) if (status < 0) return status; - if (!data) + if (!(data & DEV_INT)) return 0; status = ccg_write(uc, CCGX_RAB_INTR_REG, &data, sizeof(data));