| Message ID | 20220304073504.GA26464@kili (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b07cabb8361dc692522538205552b1b9dab134be |
| Headers | show |
| Series | USB: storage: ums-realtek: fix error code in rts51x_read_mem() | expand |
On Fri, Mar 04, 2022 at 10:35:04AM +0300, Dan Carpenter wrote: > The rts51x_read_mem() function should return negative error codes. > Currently if the kmalloc() fails it returns USB_STOR_TRANSPORT_ERROR (3) > which is treated as success by the callers. > > Fixes: 065e60964e29 ("ums_realtek: do not use stack memory for DMA") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- Acked-by: Alan Stern <stern@rowland.harvard.edu> > drivers/usb/storage/realtek_cr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c > index 3789698d9d3c..0c423916d7bf 100644 > --- a/drivers/usb/storage/realtek_cr.c > +++ b/drivers/usb/storage/realtek_cr.c > @@ -365,7 +365,7 @@ static int rts51x_read_mem(struct us_data *us, u16 addr, u8 *data, u16 len) > > buf = kmalloc(len, GFP_NOIO); > if (buf == NULL) > - return USB_STOR_TRANSPORT_ERROR; > + return -ENOMEM; > > usb_stor_dbg(us, "addr = 0x%x, len = %d\n", addr, len); > > -- > 2.20.1 >
diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c index 3789698d9d3c..0c423916d7bf 100644 --- a/drivers/usb/storage/realtek_cr.c +++ b/drivers/usb/storage/realtek_cr.c @@ -365,7 +365,7 @@ static int rts51x_read_mem(struct us_data *us, u16 addr, u8 *data, u16 len) buf = kmalloc(len, GFP_NOIO); if (buf == NULL) - return USB_STOR_TRANSPORT_ERROR; + return -ENOMEM; usb_stor_dbg(us, "addr = 0x%x, len = %d\n", addr, len);
The rts51x_read_mem() function should return negative error codes. Currently if the kmalloc() fails it returns USB_STOR_TRANSPORT_ERROR (3) which is treated as success by the callers. Fixes: 065e60964e29 ("ums_realtek: do not use stack memory for DMA") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/usb/storage/realtek_cr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)