| Message ID | 20220630115109.7522-1-oneukum@suse.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7fa2d1707d4102a5b3dcd3f49b235015f4d66955 |
| Headers | show |
| Series | cdc-eem: always use BIT | expand |
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Thu, 30 Jun 2022 13:51:09 +0200 you wrote: > Either you use BIT(x) or 1 << x in the same expression. > Mixing them is ridiculous. Go to BIT() > > Signed-off-by: Oliver Neukum <oneukum@suse.com> > --- > drivers/net/usb/cdc_eem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - cdc-eem: always use BIT https://git.kernel.org/netdev/net-next/c/7fa2d1707d41 You are awesome, thank you!
diff --git a/drivers/net/usb/cdc_eem.c b/drivers/net/usb/cdc_eem.c index 359ea0d10e59..baa9b14b1644 100644 --- a/drivers/net/usb/cdc_eem.c +++ b/drivers/net/usb/cdc_eem.c @@ -218,7 +218,7 @@ static int eem_rx_fixup(struct usbnet *dev, struct sk_buff *skb) if (unlikely(!skb2)) goto next; skb_trim(skb2, len); - put_unaligned_le16(BIT(15) | (1 << 11) | len, + put_unaligned_le16(BIT(15) | BIT(11) | len, skb_push(skb2, 2)); eem_linkcmd(dev, skb2); break;
Either you use BIT(x) or 1 << x in the same expression. Mixing them is ridiculous. Go to BIT() Signed-off-by: Oliver Neukum <oneukum@suse.com> --- drivers/net/usb/cdc_eem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)