| Message ID | 20221019225709.1506515-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b9589c417fedab6b963cf084ef305665166f5326 |
| Headers | show |
| Series | thunderbolt: remove redundant assignment to variable len | expand |
On Wed, Oct 19, 2022 at 11:57:09PM +0100, Colin Ian King wrote: > The variable len is assigned a value that is never read. It is re-assigned > a new value in the following do-while loop and never referenced after > the loop. The assignment is redundant and can be removed. > > Cleans up clang scan build warning: > drivers/thunderbolt/xdomain.c:344:2: warning: Value stored to 'len' is > never read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Applied to thunderbolt.git/next, thanks!
diff --git a/drivers/thunderbolt/xdomain.c b/drivers/thunderbolt/xdomain.c index f00b2f62d8e3..5e99f93ee1a1 100644 --- a/drivers/thunderbolt/xdomain.c +++ b/drivers/thunderbolt/xdomain.c @@ -341,7 +341,6 @@ static int tb_xdp_properties_request(struct tb_ctl *ctl, u64 route, memcpy(&req.src_uuid, src_uuid, sizeof(*src_uuid)); memcpy(&req.dst_uuid, dst_uuid, sizeof(*dst_uuid)); - len = 0; data_len = 0; do {
The variable len is assigned a value that is never read. It is re-assigned a new value in the following do-while loop and never referenced after the loop. The assignment is redundant and can be removed. Cleans up clang scan build warning: drivers/thunderbolt/xdomain.c:344:2: warning: Value stored to 'len' is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/thunderbolt/xdomain.c | 1 - 1 file changed, 1 deletion(-)