diff mbox series

usb: ehci-orion: use devm_platform_get_and_ioremap_resource()

Message ID 202211111433143392243@zte.com.cn (mailing list archive)
State New, archived
Headers show
Series usb: ehci-orion: use devm_platform_get_and_ioremap_resource() | expand

Commit Message

ye.xingchen@zte.com.cn Nov. 11, 2022, 6:33 a.m. UTC 
From: Minghao Chi <chi.minghao@zte.com.cn>

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
 drivers/usb/host/ehci-orion.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Greg KH Nov. 15, 2022, 10:33 a.m. UTC | #1 
On Fri, Nov 11, 2022 at 02:33:14PM +0800, ye.xingchen@zte.com.cn wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>

You did not follow the rules when using a tool to find and fix problems,
please read the documentation for how to do so correctly.

> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>

Your email is showing up as being invalid, and spoofed, please work with
your domain to properly handle verified email otherwise it will not be
able to be accepted.

thanks,

greg k-h
diff mbox series

Patch

diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb/host/ehci-orion.c
index a3454a3ea4e0..d0970caf3c3a 100644
--- a/drivers/usb/host/ehci-orion.c
+++ b/drivers/usb/host/ehci-orion.c
@@ -234,8 +234,7 @@  static int ehci_orion_drv_probe(struct platform_device *pdev)
 	if (err)
 		goto err;

-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	regs = devm_ioremap_resource(&pdev->dev, res);
+	regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
 	if (IS_ERR(regs)) {
 		err = PTR_ERR(regs);
 		goto err;