| Message ID | 20221121154513.51957-1-santiago.ruano-rincon@imt-atlantique.fr (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | net/cdc_ncm: Fix multicast RX support for CDC NCM devices with ZLP | expand |
On Mon, Nov 21, 2022 at 04:45:13PM +0100, Santiago Ruano Rincón wrote: > ZLP for DisplayLink ethernet devices was enabled in 6.0: > 266c0190aee3 ("net/cdc_ncm: Enable ZLP for DisplayLink ethernet devices"). > The related driver_info should be the "same as cdc_ncm_info, but with > FLAG_SEND_ZLP". However, set_rx_mode that enables handling multicast > traffic was missing in the new cdc_ncm_zlp_info. > > usbnet_cdc_update_filter rx mode was introduced in linux 5.9 with: > e10dcb1b6ba7 ("net: cdc_ncm: hook into set_rx_mode to admit multicast > traffic") > > Without this hook, multicast, and then IPv6 SLAAC, is broken. > > Fixes: 266c0190aee3 ("net/cdc_ncm: Enable ZLP for DisplayLink ethernet devices") > Signed-off-by: Santiago Ruano Rincón <santiago.ruano-rincon@imt-atlantique.fr> > --- > drivers/net/usb/cdc_ncm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c > index 8d5cbda33f66..0897fdb6254b 100644 > --- a/drivers/net/usb/cdc_ncm.c > +++ b/drivers/net/usb/cdc_ncm.c > @@ -1915,6 +1915,7 @@ static const struct driver_info cdc_ncm_zlp_info = { > .status = cdc_ncm_status, > .rx_fixup = cdc_ncm_rx_fixup, > .tx_fixup = cdc_ncm_tx_fixup, > + .set_rx_mode = usbnet_cdc_update_filter, > }; > > /* Same as cdc_ncm_info, but with FLAG_WWAN */ > -- > 2.38.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c index 8d5cbda33f66..0897fdb6254b 100644 --- a/drivers/net/usb/cdc_ncm.c +++ b/drivers/net/usb/cdc_ncm.c @@ -1915,6 +1915,7 @@ static const struct driver_info cdc_ncm_zlp_info = { .status = cdc_ncm_status, .rx_fixup = cdc_ncm_rx_fixup, .tx_fixup = cdc_ncm_tx_fixup, + .set_rx_mode = usbnet_cdc_update_filter, }; /* Same as cdc_ncm_info, but with FLAG_WWAN */
ZLP for DisplayLink ethernet devices was enabled in 6.0: 266c0190aee3 ("net/cdc_ncm: Enable ZLP for DisplayLink ethernet devices"). The related driver_info should be the "same as cdc_ncm_info, but with FLAG_SEND_ZLP". However, set_rx_mode that enables handling multicast traffic was missing in the new cdc_ncm_zlp_info. usbnet_cdc_update_filter rx mode was introduced in linux 5.9 with: e10dcb1b6ba7 ("net: cdc_ncm: hook into set_rx_mode to admit multicast traffic") Without this hook, multicast, and then IPv6 SLAAC, is broken. Fixes: 266c0190aee3 ("net/cdc_ncm: Enable ZLP for DisplayLink ethernet devices") Signed-off-by: Santiago Ruano Rincón <santiago.ruano-rincon@imt-atlantique.fr> --- drivers/net/usb/cdc_ncm.c | 1 + 1 file changed, 1 insertion(+)