| Message ID | 20230120122714.3848784-1-alexander.stein@ew.tq-group.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5d3d01ae15d2f37ed0325c99ab47ef0ae5d05f3c |
| Headers | show |
| Series | [1/1] usb: host: ehci-fsl: Fix module alias | expand |
On Fri, Jan 20, 2023 at 01:27:14PM +0100, Alexander Stein wrote: > Commit ca07e1c1e4a6 ("drivers:usb:fsl:Make fsl ehci drv an independent > driver module") changed DRV_NAME which was used for MODULE_ALIAS as well. > Starting from this the module alias didn't match the platform device > name created in fsl-mph-dr-of.c > Change DRV_NAME to match the driver name for host mode in fsl-mph-dr-of. > This is needed for module autoloading on ls1021a. > > Fixes: ca07e1c1e4a6 ("drivers:usb:fsl:Make fsl ehci drv an independent driver module") > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- Acked-by: Alan Stern <stern@rowland.harvard.edu> Does this need to go in a -stable kernel? > drivers/usb/host/ehci-fsl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c > index 3d21946e8822a..92ec655fd09b6 100644 > --- a/drivers/usb/host/ehci-fsl.c > +++ b/drivers/usb/host/ehci-fsl.c > @@ -29,7 +29,7 @@ > #include "ehci-fsl.h" > > #define DRIVER_DESC "Freescale EHCI Host controller driver" > -#define DRV_NAME "ehci-fsl" > +#define DRV_NAME "fsl-ehci" > > static struct hc_driver __read_mostly fsl_ehci_hc_driver; > > -- > 2.34.1 >
On Fri, Jan 20, 2023 at 11:34:43AM -0500, Alan Stern wrote: > On Fri, Jan 20, 2023 at 01:27:14PM +0100, Alexander Stein wrote: > > Commit ca07e1c1e4a6 ("drivers:usb:fsl:Make fsl ehci drv an independent > > driver module") changed DRV_NAME which was used for MODULE_ALIAS as well. > > Starting from this the module alias didn't match the platform device > > name created in fsl-mph-dr-of.c > > Change DRV_NAME to match the driver name for host mode in fsl-mph-dr-of. > > This is needed for module autoloading on ls1021a. > > > > Fixes: ca07e1c1e4a6 ("drivers:usb:fsl:Make fsl ehci drv an independent driver module") > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > --- > > Acked-by: Alan Stern <stern@rowland.harvard.edu> > > Does this need to go in a -stable kernel? I've already marked it to be included in stable kernels, thanks. greg k-h
diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c index 3d21946e8822a..92ec655fd09b6 100644 --- a/drivers/usb/host/ehci-fsl.c +++ b/drivers/usb/host/ehci-fsl.c @@ -29,7 +29,7 @@ #include "ehci-fsl.h" #define DRIVER_DESC "Freescale EHCI Host controller driver" -#define DRV_NAME "ehci-fsl" +#define DRV_NAME "fsl-ehci" static struct hc_driver __read_mostly fsl_ehci_hc_driver;
Commit ca07e1c1e4a6 ("drivers:usb:fsl:Make fsl ehci drv an independent driver module") changed DRV_NAME which was used for MODULE_ALIAS as well. Starting from this the module alias didn't match the platform device name created in fsl-mph-dr-of.c Change DRV_NAME to match the driver name for host mode in fsl-mph-dr-of. This is needed for module autoloading on ls1021a. Fixes: ca07e1c1e4a6 ("drivers:usb:fsl:Make fsl ehci drv an independent driver module") Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- drivers/usb/host/ehci-fsl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)