diff mbox series

[v2] usb: core: add quirk for Alcor Link AK9563 smartcard reader

Message ID 20230208165018.1088701-1-mpearson-lenovo@squebb.ca (mailing list archive)
State Superseded
Headers show
Series [v2] usb: core: add quirk for Alcor Link AK9563 smartcard reader | expand

Commit Message

Mark Pearson Feb. 8, 2023, 4:50 p.m. UTC 
The Alcor Link AK9563 smartcard reader used on some Lenovo platforms
doesn't work. If LPM is enabled the reader will provide an invalid
usb config descriptor. Added quirk to disable LPM.

Verified fix on Lenovo P16 G1 and T14 G3

Tested-by: Miroslav Zatko <mzatko@mirexoft.com>
Tested-by: Dennis Wassenberg <dennis.wassenberg@secunet.com>
Cc: stable@vger.kernel.org

Signed-off-by: Dennis Wassenberg <dennis.wassenberg@secunet.com>
Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
---
Changes in v2: Put entry in correct position in quirks list.

 drivers/usb/core/quirks.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Greg KH Feb. 8, 2023, 5:01 p.m. UTC | #1 
On Wed, Feb 08, 2023 at 11:50:18AM -0500, Mark Pearson wrote:
> The Alcor Link AK9563 smartcard reader used on some Lenovo platforms
> doesn't work. If LPM is enabled the reader will provide an invalid
> usb config descriptor. Added quirk to disable LPM.
> 
> Verified fix on Lenovo P16 G1 and T14 G3
> 
> Tested-by: Miroslav Zatko <mzatko@mirexoft.com>
> Tested-by: Dennis Wassenberg <dennis.wassenberg@secunet.com>
> Cc: stable@vger.kernel.org
> 

Blank line still not needed :(

> Signed-off-by: Dennis Wassenberg <dennis.wassenberg@secunet.com>
> Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
> ---
> Changes in v2: Put entry in correct position in quirks list.

Still in the incorrect place :(
Mark Pearson Feb. 8, 2023, 6:09 p.m. UTC | #2 
> > Changes in v2: Put entry in correct position in quirks list.
> 
> Still in the incorrect place :(
> 
I'm an idiot - I sent the wrong file. Really sorry. Gah.
Third time lucky coming up..

Mark
diff mbox series

Patch

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 079e183cf3bf..9b1c56646ac5 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -535,6 +535,9 @@  static const struct usb_device_id usb_quirk_list[] = {
 	/* INTEL VALUE SSD */
 	{ USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME },
 
+	/* Alcor Link AK9563 SC Reader used in 2022 Lenovo ThinkPads */
+	{ USB_DEVICE(0x2ce3, 0x9563), .driver_info = USB_QUIRK_NO_LPM },
+
 	{ }  /* terminating entry must be last */
 };