| Message ID | 20230411053550.16360-2-stanley_chang@realtek.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/2] usb: dwc3: core: add support for disabling High-speed park mode | expand |
+Rob On Tue, Apr 11, 2023, Stanley Chang wrote: > Add a new 'snps,parkmode-disable-hs-quirk' DT quirk to dwc3 core for > disable the high-speed parkmode. > > Signed-off-by: Stanley Chang <stanley_chang@realtek.com> > --- > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > index be36956af53b..45ca967b8d14 100644 > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > @@ -232,6 +232,11 @@ properties: > When set, all SuperSpeed bus instances in park mode are disabled. > type: boolean > > + snps,parkmode-disable-hs-quirk: > + description: > + When set, all HighSpeed bus instances in park mode are disabled. > + type: boolean > + > snps,dis_metastability_quirk: > description: > When set, disable metastability workaround. CAUTION! Use only if you are > -- > 2.34.1 > Please also Cc the devicetree maintainer. Reviewed-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com> Thanks, Thinh
On 11/04/2023 23:35, Thinh Nguyen wrote: > +Rob > > On Tue, Apr 11, 2023, Stanley Chang wrote: >> Add a new 'snps,parkmode-disable-hs-quirk' DT quirk to dwc3 core for >> disable the high-speed parkmode. >> >> Signed-off-by: Stanley Chang <stanley_chang@realtek.com> >> --- >> Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >> index be36956af53b..45ca967b8d14 100644 >> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >> @@ -232,6 +232,11 @@ properties: >> When set, all SuperSpeed bus instances in park mode are disabled. >> type: boolean >> >> + snps,parkmode-disable-hs-quirk: >> + description: >> + When set, all HighSpeed bus instances in park mode are disabled. >> + type: boolean >> + >> snps,dis_metastability_quirk: >> description: >> When set, disable metastability workaround. CAUTION! Use only if you are >> -- >> 2.34.1 >> > > Please also Cc the devicetree maintainer. > No, please use scripts/get_maintainers.pl Best regards, Krzysztof
On 11/04/2023 07:35, Stanley Chang wrote: > Add a new 'snps,parkmode-disable-hs-quirk' DT quirk to dwc3 core for > disable the high-speed parkmode. > > Signed-off-by: Stanley Chang <stanley_chang@realtek.com> > --- > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++ > 1 file changed, 5 insertions(+) NAK, so Greg won't pick it up too fast. :) Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Best regards, Krzysztof
> On 11/04/2023 07:35, Stanley Chang wrote: > > Add a new 'snps,parkmode-disable-hs-quirk' DT quirk to dwc3 core for > > disable the high-speed parkmode. > > > > Signed-off-by: Stanley Chang <stanley_chang@realtek.com> > > --- > > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > NAK, so Greg won't pick it up too fast. :) > > Please use scripts/get_maintainers.pl to get a list of necessary people and lists > to CC. It might happen, that command when run on an older kernel, gives > you outdated entries. Therefore please be sure you base your patches on > recent Linux kernel. > > Best regards, > Krzysztof > CC more maintainers by using scripts/get_maintainers.pl Thanks, Stanley
On 12/04/2023 13:10, Stanley Chang[昌育德] wrote: >> On 11/04/2023 07:35, Stanley Chang wrote: >>> Add a new 'snps,parkmode-disable-hs-quirk' DT quirk to dwc3 core for >>> disable the high-speed parkmode. >>> >>> Signed-off-by: Stanley Chang <stanley_chang@realtek.com> >>> --- >>> Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++ >>> 1 file changed, 5 insertions(+) >> >> NAK, so Greg won't pick it up too fast. :) >> >> Please use scripts/get_maintainers.pl to get a list of necessary people and lists >> to CC. It might happen, that command when run on an older kernel, gives >> you outdated entries. Therefore please be sure you base your patches on >> recent Linux kernel. >> >> Best regards, >> Krzysztof >> > > CC more maintainers by using scripts/get_maintainers.pl > This does not work like this. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml index be36956af53b..45ca967b8d14 100644 --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml @@ -232,6 +232,11 @@ properties: When set, all SuperSpeed bus instances in park mode are disabled. type: boolean + snps,parkmode-disable-hs-quirk: + description: + When set, all HighSpeed bus instances in park mode are disabled. + type: boolean + snps,dis_metastability_quirk: description: When set, disable metastability workaround. CAUTION! Use only if you are
Add a new 'snps,parkmode-disable-hs-quirk' DT quirk to dwc3 core for disable the high-speed parkmode. Signed-off-by: Stanley Chang <stanley_chang@realtek.com> --- Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++ 1 file changed, 5 insertions(+)