| Message ID | 20230602102644.77470-5-pawell@cadence.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 41e2f976b558ca71fb79dbc7874c4fc91370b5d6 |
| Headers | show |
| Series | Introduced new Cadence USBHS Driver | expand |
On Fri, Jun 02, 2023 at 06:26:44AM -0400, Pawel Laszczak wrote: > Patch adds entry for USBHS (CDNS2) driver into MAINTARNERS file > > Signed-off-by: Pawel Laszczak <pawell@cadence.com> > --- > MAINTAINERS | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index c269a15609e2..8b289d52d983 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -4523,6 +4523,12 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git > F: drivers/usb/cdns3/ > X: drivers/usb/cdns3/cdns3* > > +CADENCE USBHS DRIVER > +M: Pawel Laszczak <pawell@cadence.com> > +L: linux-usb@vger.kernel.org > +S: Maintained This isn't part of your job description? Why doesn't Cadence allow you to do that? That's not good on a bunch of levels, have you seen the Documentation/process/contribution-maturity-model.rst file yet? thanks, greg k-h
> >On Fri, Jun 02, 2023 at 06:26:44AM -0400, Pawel Laszczak wrote: >> Patch adds entry for USBHS (CDNS2) driver into MAINTARNERS file >> >> Signed-off-by: Pawel Laszczak <pawell@cadence.com> >> --- >> MAINTAINERS | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS index >> c269a15609e2..8b289d52d983 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -4523,6 +4523,12 @@ T: git >git://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git >> F: drivers/usb/cdns3/ >> X: drivers/usb/cdns3/cdns3* >> >> +CADENCE USBHS DRIVER >> +M: Pawel Laszczak <pawell@cadence.com> >> +L: linux-usb@vger.kernel.org >> +S: Maintained > >This isn't part of your job description? Why doesn't Cadence allow you to do >that? That's not good on a bunch of levels, have you seen the >Documentation/process/contribution-maturity-model.rst file yet? > I have read it now, but I don't understand where I made mistake. I guess that I should not be added as maintainer. Am I right? I responsible for: 1. developing USBHS driver 2. upstreaming USBH driver 3. fixing issue detected by me or by our customers. Thanks, Pawel >thanks, > >greg k-h
On Wed, Jun 14, 2023 at 05:45:46AM +0000, Pawel Laszczak wrote: > > > > >On Fri, Jun 02, 2023 at 06:26:44AM -0400, Pawel Laszczak wrote: > >> Patch adds entry for USBHS (CDNS2) driver into MAINTARNERS file > >> > >> Signed-off-by: Pawel Laszczak <pawell@cadence.com> > >> --- > >> MAINTAINERS | 6 ++++++ > >> 1 file changed, 6 insertions(+) > >> > >> diff --git a/MAINTAINERS b/MAINTAINERS index > >> c269a15609e2..8b289d52d983 100644 > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -4523,6 +4523,12 @@ T: git > >git://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git > >> F: drivers/usb/cdns3/ > >> X: drivers/usb/cdns3/cdns3* > >> > >> +CADENCE USBHS DRIVER > >> +M: Pawel Laszczak <pawell@cadence.com> > >> +L: linux-usb@vger.kernel.org > >> +S: Maintained > > > >This isn't part of your job description? Why doesn't Cadence allow you to do > >that? That's not good on a bunch of levels, have you seen the > >Documentation/process/contribution-maturity-model.rst file yet? > > > > I have read it now, but I don't understand where I made mistake. > I guess that I should not be added as maintainer. Am I right? > > I responsible for: > 1. developing USBHS driver > 2. upstreaming USBH driver > 3. fixing issue detected by me or by our customers. It's the "S: Maintained" line I am curious about. "Maintained" means "Someone actually looks after it.", while if you put "Supported" that means "Someone is actually paid to look after this." The difference is the first is usually on your own time as a best-effort on your part, the second is that it is part of your job from your employer. If Cadence doesn't allow you to do maintaince work on company time, then the entry is correct as you wrote it. Otherwise you might want to change that. See the top of the MAINTAINERS file for the other options you have here for this field if neither of these are correct. thanks, greg k-h
diff --git a/MAINTAINERS b/MAINTAINERS index c269a15609e2..8b289d52d983 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4523,6 +4523,12 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git F: drivers/usb/cdns3/ X: drivers/usb/cdns3/cdns3* +CADENCE USBHS DRIVER +M: Pawel Laszczak <pawell@cadence.com> +L: linux-usb@vger.kernel.org +S: Maintained +F: drivers/usb/gadget/udc/cdns2 + CADET FM/AM RADIO RECEIVER DRIVER M: Hans Verkuil <hverkuil@xs4all.nl> L: linux-media@vger.kernel.org
Patch adds entry for USBHS (CDNS2) driver into MAINTARNERS file Signed-off-by: Pawel Laszczak <pawell@cadence.com> --- MAINTAINERS | 6 ++++++ 1 file changed, 6 insertions(+)