diff mbox series

[v2,3/3] USB: serial: report unsupported break signalling

Message ID 20230604123505.4661-4-johan@kernel.org (mailing list archive)
State Accepted
Commit c9d934053d9e850bc901b6425eacb5fe3d4b1738
Headers show
Series USB: serial: return errors from break handling | expand

Commit Message

Johan Hovold June 4, 2023, 12:35 p.m. UTC 
Instead of returning success when a driver does not support break
signalling, return an error to let user space know and to avoid waiting
when break is not supported.

Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/usb/serial/usb-serial.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c
index 470634444af7..7b4805c1004d 100644
--- a/drivers/usb/serial/usb-serial.c
+++ b/drivers/usb/serial/usb-serial.c
@@ -541,7 +541,7 @@  static int serial_break(struct tty_struct *tty, int break_state)
 	if (port->serial->type->break_ctl)
 		return port->serial->type->break_ctl(tty, break_state);
 
-	return 0;
+	return -ENOTTY;
 }
 
 static int serial_proc_show(struct seq_file *m, void *v)