| Message ID | 20230605204010.2239676-1-pholla@chromium.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | usb: typec: Fix fast_role_swap_current show function | expand |
Hi Pavan, On Mon, Jun 5, 2023 at 1:40 PM Pavan Holla <pholla@chromium.org> wrote: > > The current implementation mistakenly performs a & operation on > the output of sysfs_emit. This patch performs the & operation before > calling sysfs_emit. > > Series-to: LKML <linux-kernel@vger.kernel.org> > Signed-off-by: Pavan Holla <pholla@chromium.org> Reviewed-by: Benson Leung <bleung@chromium.org> Thanks! Benson > --- > drivers/usb/typec/pd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/pd.c b/drivers/usb/typec/pd.c > index 0bcde1ff4d39..8cc66e4467c4 100644 > --- a/drivers/usb/typec/pd.c > +++ b/drivers/usb/typec/pd.c > @@ -95,7 +95,7 @@ peak_current_show(struct device *dev, struct device_attribute *attr, char *buf) > static ssize_t > fast_role_swap_current_show(struct device *dev, struct device_attribute *attr, char *buf) > { > - return sysfs_emit(buf, "%u\n", to_pdo(dev)->pdo >> PDO_FIXED_FRS_CURR_SHIFT) & 3; > + return sysfs_emit(buf, "%u\n", (to_pdo(dev)->pdo >> PDO_FIXED_FRS_CURR_SHIFT) & 3); > } > static DEVICE_ATTR_RO(fast_role_swap_current); > > -- > 2.41.0.rc0.172.g3f132b7071-goog >
On Mon, Jun 05, 2023 at 08:40:09PM +0000, Pavan Holla wrote: > The current implementation mistakenly performs a & operation on > the output of sysfs_emit. This patch performs the & operation before > calling sysfs_emit. > > Series-to: LKML <linux-kernel@vger.kernel.org> What is this line for? What commit id does this fix? thanks, greg k-h
On Mon, Jun 5, 2023 at 11:47 PM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > On Mon, Jun 05, 2023 at 08:40:09PM +0000, Pavan Holla wrote: > > The current implementation mistakenly performs a & operation on > > the output of sysfs_emit. This patch performs the & operation before > > calling sysfs_emit. > > > > Series-to: LKML <linux-kernel@vger.kernel.org> > > What is this line for? > Sorry, this was intended for a tool that simplifies git send-email. I ended up not using the tool, but forgot to delete the tag. > What commit id does this fix? > Fixes: 662a60102c12 ("usb: typec: Separate USB Power Delivery from USB Type-C") > thanks, > > greg k-h Please look out for V2 of this patch. Thanks, Pavan
diff --git a/drivers/usb/typec/pd.c b/drivers/usb/typec/pd.c index 0bcde1ff4d39..8cc66e4467c4 100644 --- a/drivers/usb/typec/pd.c +++ b/drivers/usb/typec/pd.c @@ -95,7 +95,7 @@ peak_current_show(struct device *dev, struct device_attribute *attr, char *buf) static ssize_t fast_role_swap_current_show(struct device *dev, struct device_attribute *attr, char *buf) { - return sysfs_emit(buf, "%u\n", to_pdo(dev)->pdo >> PDO_FIXED_FRS_CURR_SHIFT) & 3; + return sysfs_emit(buf, "%u\n", (to_pdo(dev)->pdo >> PDO_FIXED_FRS_CURR_SHIFT) & 3); } static DEVICE_ATTR_RO(fast_role_swap_current);
The current implementation mistakenly performs a & operation on the output of sysfs_emit. This patch performs the & operation before calling sysfs_emit. Series-to: LKML <linux-kernel@vger.kernel.org> Signed-off-by: Pavan Holla <pholla@chromium.org> --- drivers/usb/typec/pd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)