| Message ID | 20240219061008.1761102-2-pumahsu@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | usb: xhci: Add support for Google XHCI controller | expand |
On 19/02/2024 07:10, Puma Hsu wrote: > Currently the dwc3 driver always probes xhci-plat driver Not a DT property, at least at first glance. NAK. > by hardcode in driver. Introduce a property to make this > flexible that a user can probe a xhci glue driver by the > generic dwc3 driver. > > Signed-off-by: Puma Hsu <pumahsu@google.com> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline), work on fork of kernel (don't, instead use mainline) or you ignore some maintainers (really don't). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/usb/usb-drd.yaml b/Documentation/devicetree/bindings/usb/usb-drd.yaml index 114fb5dc0498..215fb7f70054 100644 --- a/Documentation/devicetree/bindings/usb/usb-drd.yaml +++ b/Documentation/devicetree/bindings/usb/usb-drd.yaml @@ -62,6 +62,12 @@ properties: enum: [host, peripheral] default: peripheral + xhci-glue: + description: + Tell dwc3 core driver what xhci specific platform driver we want to probe. + The string should match to the name of device_driver of platform_driver + in the xhci specific platform driver. + additionalProperties: true examples: @@ -76,4 +82,5 @@ examples: phy_type = "utmi_wide"; otg-rev = <0x0200>; adp-disable; + xhci-glue = "xhci-hcd-plat"; };
Currently the dwc3 driver always probes xhci-plat driver by hardcode in driver. Introduce a property to make this flexible that a user can probe a xhci glue driver by the generic dwc3 driver. Signed-off-by: Puma Hsu <pumahsu@google.com> --- Documentation/devicetree/bindings/usb/usb-drd.yaml | 7 +++++++ 1 file changed, 7 insertions(+)