| Message ID | 20240307105135.1981060-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [next] usb: gadget: net2272: remove redundant variable irqflags | expand |
On Thu, Mar 07, 2024 at 10:51:35AM +0000, Colin Ian King wrote: > The variable irqflags is being initialized and being bit-or'd with > values but it is never read afterwards. The variable is redundant > and can be removed. > > Cleans up clang scan build warning: > drivers/usb/gadget/udc/net2272.c:2610:15: warning: variable 'irqflags' > set but not used [-Wunused-but-set-variable] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> this "problem" exists since the driver was introduced in commit ceb80363b2ec ("USB: net2272: driver for PLX NET2272 USB device controller"). Might be worth a Fixes: line. I wonder if the better fix would be: diff --git a/drivers/usb/gadget/udc/net2272.c b/drivers/usb/gadget/udc/net2272.c index 12e76bb62c20..19bbc38f3d35 100644 --- a/drivers/usb/gadget/udc/net2272.c +++ b/drivers/usb/gadget/udc/net2272.c @@ -2650,7 +2650,7 @@ net2272_plat_probe(struct platform_device *pdev) goto err_req; } - ret = net2272_probe_fin(dev, IRQF_TRIGGER_LOW); + ret = net2272_probe_fin(dev, irqflags); if (ret) goto err_io; Best regards Uwe
On Thu, Mar 07, 2024 at 05:51:59PM +0100, Uwe Kleine-König wrote: > On Thu, Mar 07, 2024 at 10:51:35AM +0000, Colin Ian King wrote: > > The variable irqflags is being initialized and being bit-or'd with > > values but it is never read afterwards. The variable is redundant > > and can be removed. > > > > Cleans up clang scan build warning: > > drivers/usb/gadget/udc/net2272.c:2610:15: warning: variable 'irqflags' > > set but not used [-Wunused-but-set-variable] > > > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > > this "problem" exists since the driver was introduced in commit > ceb80363b2ec ("USB: net2272: driver for PLX NET2272 USB device > controller"). Might be worth a Fixes: line. > > I wonder if the better fix would be: > > diff --git a/drivers/usb/gadget/udc/net2272.c b/drivers/usb/gadget/udc/net2272.c > index 12e76bb62c20..19bbc38f3d35 100644 > --- a/drivers/usb/gadget/udc/net2272.c > +++ b/drivers/usb/gadget/udc/net2272.c > @@ -2650,7 +2650,7 @@ net2272_plat_probe(struct platform_device *pdev) > goto err_req; > } > > - ret = net2272_probe_fin(dev, IRQF_TRIGGER_LOW); > + ret = net2272_probe_fin(dev, irqflags); > if (ret) > goto err_io; I agree, that makes much more sense. Alan Stern
On 07/03/2024 17:29, Alan Stern wrote: > On Thu, Mar 07, 2024 at 05:51:59PM +0100, Uwe Kleine-König wrote: >> On Thu, Mar 07, 2024 at 10:51:35AM +0000, Colin Ian King wrote: >>> The variable irqflags is being initialized and being bit-or'd with >>> values but it is never read afterwards. The variable is redundant >>> and can be removed. >>> >>> Cleans up clang scan build warning: >>> drivers/usb/gadget/udc/net2272.c:2610:15: warning: variable 'irqflags' >>> set but not used [-Wunused-but-set-variable] >>> >>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com> >> >> this "problem" exists since the driver was introduced in commit >> ceb80363b2ec ("USB: net2272: driver for PLX NET2272 USB device >> controller"). Might be worth a Fixes: line. >> >> I wonder if the better fix would be: >> >> diff --git a/drivers/usb/gadget/udc/net2272.c b/drivers/usb/gadget/udc/net2272.c >> index 12e76bb62c20..19bbc38f3d35 100644 >> --- a/drivers/usb/gadget/udc/net2272.c >> +++ b/drivers/usb/gadget/udc/net2272.c >> @@ -2650,7 +2650,7 @@ net2272_plat_probe(struct platform_device *pdev) >> goto err_req; >> } >> >> - ret = net2272_probe_fin(dev, IRQF_TRIGGER_LOW); >> + ret = net2272_probe_fin(dev, irqflags); >> if (ret) >> goto err_io; > > I agree, that makes much more sense. OK, I'll send a V2, but I can't test it, so I suspect that is a risk, but it is clearly wrong as it stands. Colin > > Alan Stern
diff --git a/drivers/usb/gadget/udc/net2272.c b/drivers/usb/gadget/udc/net2272.c index 12e76bb62c20..afd2a836be6d 100644 --- a/drivers/usb/gadget/udc/net2272.c +++ b/drivers/usb/gadget/udc/net2272.c @@ -2607,7 +2607,6 @@ net2272_plat_probe(struct platform_device *pdev) { struct net2272 *dev; int ret; - unsigned int irqflags; resource_size_t base, len; struct resource *iomem, *iomem_bus, *irq_res; @@ -2623,16 +2622,6 @@ net2272_plat_probe(struct platform_device *pdev) if (IS_ERR(dev)) return PTR_ERR(dev); - irqflags = 0; - if (irq_res->flags & IORESOURCE_IRQ_HIGHEDGE) - irqflags |= IRQF_TRIGGER_RISING; - if (irq_res->flags & IORESOURCE_IRQ_LOWEDGE) - irqflags |= IRQF_TRIGGER_FALLING; - if (irq_res->flags & IORESOURCE_IRQ_HIGHLEVEL) - irqflags |= IRQF_TRIGGER_HIGH; - if (irq_res->flags & IORESOURCE_IRQ_LOWLEVEL) - irqflags |= IRQF_TRIGGER_LOW; - base = iomem->start; len = resource_size(iomem); if (iomem_bus)
The variable irqflags is being initialized and being bit-or'd with values but it is never read afterwards. The variable is redundant and can be removed. Cleans up clang scan build warning: drivers/usb/gadget/udc/net2272.c:2610:15: warning: variable 'irqflags' set but not used [-Wunused-but-set-variable] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/usb/gadget/udc/net2272.c | 11 ----------- 1 file changed, 11 deletions(-)