| Message ID | 20241003121729.3867216-2-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | xhci: pci: Amend definitions of PCI device IDs | expand |
On Thu, Oct 03, 2024 at 03:14:44PM +0300, Andy Shevchenko wrote:
> Rename the PCI device ID to match what's used in another driver.
If the same device id is in multiple drivers, why not add it to
pci_ids.h like is normal to do?
thanks,
greg k-h
On Fri, Oct 04, 2024 at 09:48:35AM +0200, Greg Kroah-Hartman wrote: > On Thu, Oct 03, 2024 at 03:14:44PM +0300, Andy Shevchenko wrote: > > Rename the PCI device ID to match what's used in another driver. > > If the same device id is in multiple drivers, why not add it to > pci_ids.h like is normal to do? Also an option. So, Mathias, please, skip the first patch, seems we can do better.
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c index 295d3297ca3d..2c148b143c54 100644 --- a/drivers/usb/host/xhci-pci.c +++ b/drivers/usb/host/xhci-pci.c @@ -81,7 +81,7 @@ #define PCI_DEVICE_ID_ASMEDIA_2142_XHCI 0x2142 #define PCI_DEVICE_ID_ASMEDIA_3242_XHCI 0x3242 -#define PCI_DEVICE_ID_CDNS_SSP 0x0200 +#define PCI_DEVICE_ID_CDNS_UDC 0x0200 static const char hcd_name[] = "xhci_hcd"; @@ -475,8 +475,9 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci) if (pdev->device == 0x9203) xhci->quirks |= XHCI_ZHAOXIN_TRB_FETCH; } + if (pdev->vendor == PCI_VENDOR_ID_CDNS && - pdev->device == PCI_DEVICE_ID_CDNS_SSP) + pdev->device == PCI_DEVICE_ID_CDNS_UDC) xhci->quirks |= XHCI_CDNS_SCTX_QUIRK; /* xHC spec requires PCI devices to support D3hot and D3cold */
Rename the PCI device ID to match what's used in another driver. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/usb/host/xhci-pci.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)