From patchwork Fri Oct 4 03:05:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manuel X-Patchwork-Id: 13821770 Received: from sonic304-20.consmr.mail.ne1.yahoo.com (sonic304-20.consmr.mail.ne1.yahoo.com [66.163.191.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23D95335A5 for ; Fri, 4 Oct 2024 03:36:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=66.163.191.146 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728012968; cv=none; b=kv+QwibF/jtlxsSOei2bN0A+xp4JjeKRsTVsUtK+7LIA1M3U+ME41qd4jTI4/0kSlLDoJh6WnBUG1qzHJpb3m7v0TfS/oNBxLErsvpYNsTTQxCvOGc0kTweVwxo1ljwFdtXaTvbW5V0HgQ/+XIiFhw1wkM/v9NtURG1SdQcU4hc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728012968; c=relaxed/simple; bh=VJuuzroqJgZYENLBrsW3aheh2WTfa0sOcRL9hbIbKUc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:References; b=b9HANw4cairDWbIi8GO2ASFPa+/NQB8DEcQxP9zIsZBiox7Xy2iREW494RChrk3S45v3Zf4uUBvu729dXsE1m8r2R399m0SGD83G+FUXPdSCrlZQ/0xBigOIZPXhIId82J80QpTrkCrCCNbiO+cxNqdVjLj17LKOyErs8DHMZSE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=yahoo.com; spf=pass smtp.mailfrom=yahoo.com; dkim=pass (2048-bit key) header.d=yahoo.com header.i=@yahoo.com header.b=ftCQMSqW; arc=none smtp.client-ip=66.163.191.146 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=yahoo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=yahoo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=yahoo.com header.i=@yahoo.com header.b="ftCQMSqW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1728012966; bh=fxOLENbaZk22qLVdZz3DCzbj36kx6WCUGmr+2MaK+U8=; h=From:To:Cc:Subject:Date:References:From:Subject:Reply-To; b=ftCQMSqWF9HOTeiI3juuOOfGc5FoAK0MQVKYveRYGRCIxjynq4uz6BqVfEpMfC0JxeNV1SLjK7CvE5/zJruAbFCchLCfwqBbDsoQtRpMD8i4rqJxAOUi7z1mjuIdwz0kkLmQjARq08Dy0010fktPQXM0UNElhwWOKutus4GYXt6njRsnrs5zk1W7VhimhDTdRHDAwAD4AiOVcgSi8Zjr1xxqOg0RYYI/0bAya3KwD/i4kt9Lgu65CEx4odgUiSpDycg3jGE6A+1GR99gsVJ14Z5oG2hyX9CIdi68n07MltnFXb7d1hK3ZMJ+qxbov+bWqjcNnesACFyiTwlFVOViKw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1728012966; bh=pNM1RNmIQ+QVaufB/zULdZmXxbuwINg59KiT/e/nhcB=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Kh5xuVrTYNP6rEtTKrpIVbp0UMnq3cziDECBjPGqg1p9ArCxP3WjoiZJQ1iUCEw0EU/bOj007eDdnA/8LQ+CQpolPJU9TOj5IAnfhwqqnUH/iKxYWMhthiqtyDM8fianA4oNX8dwKsVz08kltCPXn+UjLssqg9yDKQsQO9db2DwVm3RI11zpsQhLvsXujlz6m6Ywj69Liz55Ubd7cQ3+J/2gH1S61zxrV9beQe6we27K2lBcnHFm4nEx0jWHKkni+AJyNse+jCg7zMVR1iRSDx68EQr8PZUj9Yc9xvKHRa5SnYSW8r/fSsf88vNHRQ54ZBHdYbjWcnOAF+W1R8T8Wg== X-YMail-OSG: xCE0O_0VM1n_xotxNcZHDv19peA5qp5wy4JsF8ze8yFcUc0YIOVGwt.6dzFIq_P Z52fsYrNv61YGF__DbjgNkEYykhuFJ1qTfO8YpBeEtYmd0hHI3bZ5iry54IqiJBv47Mgdx60Plmd AfHHKCQWw3trF8xxPZMUpAzw8ryRLJLdVyerJiHM_abK2NPGVcCJaxyCOjpNVmKOidF63RjzR4SM g16UEZkYHQ51tPb.ZW6lK5X_Keg21XUJ50eHDclD7AIFfTtozyaWKbzXsDtRMsiM53j.MoHL5bt. BgupeJVjoMN0fiQXq3Oxy5FUAtfso89MYiu0WkKAqfEuYd1lVxhtoXWAKZDtvQKAe3ZUVsCf8czN p6WKNO9j3rFw0HzsWiKfbKoxV5pRxtU2hbne1LXatKNgYyyZCP4Ioao0g993MQicZgF00MOa3ecr 8b5Bmdsjmi_8RqLB65X_mhVLvWxB4lZZihPlDQ9RlY._L3cU7CeU5nwOOEF5ef8DZhgYF6Rnz9mg LqeRtsL1t8OkFEuFn0yr96robJMC0oJML..dh.qWB3Iw0VqyO4s2FPLRv6RzvfoWlfLwBH1qW8H_ .SdeZrkn4Ms8LhSFWE0IH1KpWh2OEDRQA3eN7DoVqmtFTmfpeKDahCIrSE3Kx7kO1_F1lNho6crq 2VskS_QnWXD.HcaUt.EwiStOCmCFzKp8thzFAILqTZpt7eEZSvbQxUl3_GR.EVAJPKiyy.rm.3T3 m9um4c8mfNpmlJEQxoPZ28i_iVBR7JJjZAXUGeTnRH7LiOqwlP8iU52Lwm7W0vGva.KLk_O0LlvE 5osZlHj.Nqc8qhxaBjs2oSkkEWPRhfLgtTBBT_lBvjUePoyJJmTgw1Tgk_iSsLwLuBziWTjevs0M qvgKM2gQb93P5NcdJSpKf7lFq5SnveCgbKGKYeNMN90AkA8qyDru51ujtFDYBnxu_R5et6ZtSdIZ yijs097FA51Zcc6osh9pKqQX2wDr8NUNkGL_UV4SufUG.7rlm6nEi7fQZDahgjOicngmCAn0r4bQ tgLAK7DP8mlP80TpIZ4gFJ8aeVPt_6yzj2fp7IqGVkJINp2yWHh59SdE92Yd.1s0YEVKihMs4RvF JA2_zMVDapo5D1UbqgAph.APvQQUSnYhiVT.rOjCODRLGCH7CvB4SYpW5MxgVDptDvq21He8K.Jo Jd7N8V7blO79BOCfqb60kQmXzRTgd5BSRQ67VW9xJXP9TtyGDBl5xJbByfQSKcjtxD5vGHMFc_qF 1Q70a7BKb2SXo5TILXd6nCeqaMUZ0UnHyFPNSmUWN6qvVAddhHvQtisscv095Hku6qXADM_iEe1Z fW1TizvcBhtGT_u9EEURr2fw9ZYnmo4ZI1dPxFEuwu2u.a1.pT3L7ZYe_Xs9QSqeTmdGSMgXsqqS E6CeONvx_J3_HkFlaxnczzfXCOfWHWSElvTrlqOxxKMkuAjHDnzXFD6cFOds6gQwmGw04_RWFliV 8kJfVh0y6RM.CZbc8aGHCjIy8Jdc_Hu6s7IXFR9NItH.fA0sJchUESqQqubQ4NZCnp8uzHNkuuB5 AGA1dYNfuf1EvtxLdI5K.yPyFCS2K5CNqoAchlrMpZQ5mjR63jW6cnsedUo3Tq6qMb.mFvpdFcFs YkQm2VwpJ73H2PUkscPHC5o9cGFER_SqtlLJAg6H.QAww3CnkZ7BAzDLbslUtiToWkb51.woRifm NukZuf5GJFrL61cH1qrCXZCJbnFj6h4ouHp2EIUY_SPf9ePPcHcgnUQ5_LvbJtuvb2ZPm9ZfxSQI NWKoGl.Y92rEL1O7TZ1fPcdrpkdR44cjARTSlXt_jWMq358zQs_fi8YwnJy04AckJWiAf3Y6vjhs CS5jEmAwGQx2ke5gbuaYSdgdp8ZsRCklWAEtzhspn7dVkHr.HfpWMxdnxAgspaYkp5Vxfbl.qIc6 myfgNysfR0zDj7cBce7zgF1cTQmukiVVkQLZBu0X38FMEYLmjN79Jdq.kvbipdBbdiqqCTfJyf0X UWMWLdr4zFEyby5ARfKp.dnG89D.RjcmNnRovae0simqIbG7DeAV4yC077vAopeGT_tKhYDizW7R NQ4IetVtDF6fvjR5tMjN2gbjk0rIT43DmnOy9eWqdPRiqa8Oo1WicJLIlD.3cdgQLUgvHStZ15Q9 1O4EWp6jCBNxBMgvgB9mkcoOjh9OFR3fcs7_NOSD6eZQnB5ye2lvWkdENv3Y0kCjckUsdmwLQP7I 1v3zC0HB9iBOSXhex1InKnEc9M3ueVlFAYX69INSTQa8SD5m.HLYKlA9cjqPXhOk- X-Sonic-MF: X-Sonic-ID: 091dc0ee-1610-478a-ba36-5e008efc94f0 Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ne1.yahoo.com with HTTP; Fri, 4 Oct 2024 03:36:06 +0000 Received: by hermes--production-gq1-5d95dc458-5n5gs (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 976521b2d41838e24b741dfbee830839; Fri, 04 Oct 2024 03:05:38 +0000 (UTC) From: Manuel Quintero F To: duncan.sands@free.fr Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Manuel Quintero F Subject: [PATCH] USB: atm: speedtch: do not use assignment in if condition Date: Thu, 3 Oct 2024 20:05:12 -0700 Message-ID: <20241004030512.2036-1-sakunix@yahoo.com> X-Mailer: git-send-email 2.45.2 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20241004030512.2036-1-sakunix.ref@yahoo.com> Fix checkpatch error "do not use assignment in if condition" Signed-off-by: Manuel Quintero F Signed-off-by: Manuel Quintero F --- drivers/usb/atm/speedtch.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/atm/speedtch.c b/drivers/usb/atm/speedtch.c index 973548b5c15c..dfd362abf602 100644 --- a/drivers/usb/atm/speedtch.c +++ b/drivers/usb/atm/speedtch.c @@ -324,7 +324,9 @@ static int speedtch_upload_firmware(struct speedtch_instance_data *instance, because we're in our own kernel thread anyway. */ msleep_interruptible(1000); - if ((ret = usb_set_interface(usb_dev, INTERFACE_DATA, instance->params.altsetting)) < 0) { + ret = usb_set_interface(usb_dev, INTERFACE_DATA, instance->params.altsetting + + if (ret < 0) { usb_err(usbatm, "%s: setting interface to %d failed (%d)!\n", __func__, instance->params.altsetting, ret); goto out_free; }